fix(bazel): use entire proto pkg for type assembly name #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakeli0
reviewed
Aug 4, 2023
bazel/src/test/data/googleapis/google/example/library/type/BUILD.bazel.baseline
Show resolved
Hide resolved
blakeli0
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the generated name for type-only assembly_pkg targets to be converted directly from the entire proto package instead of just the last two segments. It aligns better with the naming of GAPIC assembly_pkg targets, and the target names only really matter for debugging b.c bazel-bot just runs everything and captures the resulting tarballs.
Based on discussion in #169 (comment)