Skip to content

Commit

Permalink
chore: add unit tests for generate_library.sh (#1964)
Browse files Browse the repository at this point in the history
* chore: add unit tests for `generate_library.sh`

* add os types in unit tests

* add more tests

* fix broken test

* use `uname` to get os info

* split generate library golden tests

* change library

* add script level comments

* remove golden tests

* remove golden test in ci

* change proto path

* remove unused parameter

* set x separately
  • Loading branch information
JoeWang1127 committed Sep 12, 2023
1 parent 7218d80 commit 336e8f3
Show file tree
Hide file tree
Showing 5 changed files with 213 additions and 127 deletions.
6 changes: 5 additions & 1 deletion .github/workflows/verify_library_generation.yaml
Expand Up @@ -31,7 +31,11 @@ jobs:
--googleapis_gen_url https://cloud-java-bot:${{ secrets.CLOUD_JAVA_BOT_GITHUB_TOKEN }}@github.com/googleapis/googleapis-gen.git \
--os_type ${{ matrix.os }}
unit_tests:
runs-on: ubuntu-22.04
strategy:
matrix:
java: [ 8 ]
os: [ ubuntu-22.04, macos-12 ]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
- name: Run unit tests
Expand Down
1 change: 0 additions & 1 deletion library_generation/README.md
Expand Up @@ -124,4 +124,3 @@ library_generation/generate_library.sh \
--rest_numeric_enums true \
--include_samples true
```

0 comments on commit 336e8f3

Please sign in to comment.