Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gax-java(mac-os): BatcherImplTest.testThrottlingBlocking- adding elements to batcher should be blocked by FlowControlled #1931

Closed
github-actions bot opened this issue Aug 18, 2023 · 4 comments · Fixed by #2285
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@github-actions
Copy link

The build has failed : https://github.com/googleapis/gapic-generator-java/actions/runs/5897706299

@ddixit14 ddixit14 added priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern. labels Aug 18, 2023
@lqiu96
Copy link
Contributor

lqiu96 commented Sep 18, 2023

Error:

Error:  Failures: 
Error:    BatcherImplTest.testThrottlingBlocking:886 adding elements to batcher should be blocked by FlowControlled

@lqiu96 lqiu96 changed the title Nightly build for Java 11 on macOS-12 failed. gax-java(mac-os): BatcherImplTest.testThrottlingBlocking- adding elements to batcher should be blocked by FlowControlled Sep 18, 2023
@suztomo
Copy link
Member

suztomo commented Sep 18, 2023

I fixed another concurrency issue of the same test in #1193. Let's revisit this bug when we observe another occurrence.

@mpeddada1
Copy link
Contributor

Re-opening this issue. Looks like this particular error persists. We recently ran into this issue in #2057. cc/ @suztomo if you have any insights?

@suztomo
Copy link
Member

suztomo commented Dec 4, 2023

With 2285, I was able to reproduce the issue in my Mac.

~/sdk-platform-java $ (repeat 100 mvn test -pl gax-java/gax -Dtest="BatcherImplTest#testThrottlingBlocking" -Denforcer.skip=true -Dfmt.skip=true -Dcheckstyle.skip=true) |tee /tmp/test.log

...

[INFO] Running com.google.api.gax.batching.BatcherImplTest
2023 1:24:02.786 com.google.api.gax.batching.BatcherImplTest testThrottlingBlocking INFO: Calling future.get(10 ms)
2023 1:24:02.841 com.google.api.gax.batching.BatcherImplTest lambda$testThrottlingBlocking$0 INFO: Calling flowController.release
2023 1:24:02.841 com.google.api.gax.batching.BatcherImplTest lambda$testThrottlingBlocking$0 INFO: Called flowController.release
2023 1:24:02.843 com.google.api.gax.batching.BatcherImplTest testThrottlingBlocking INFO: future.get(10 ms) unexpectedly returned.
...
[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   BatcherImplTest.testThrottlingBlocking:905 adding elements to batcher should be blocked by FlowControlled

(The repeat command is zsh)

3 invocations failed out of 100.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants