Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skip generating grpc-* directory if transport is rest #1979

Merged
merged 12 commits into from Sep 14, 2023

Conversation

JoeWang1127
Copy link
Collaborator

@JoeWang1127 JoeWang1127 commented Sep 12, 2023

In this PR:

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Sep 12, 2023
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Sep 12, 2023
@JoeWang1127 JoeWang1127 changed the title chore: add proto_path in integration test chore: skip generating grpc-* directory if transport is rest Sep 12, 2023
@JoeWang1127 JoeWang1127 changed the title chore: skip generating grpc-* directory if transport is rest bugfix: skip generating grpc-* directory if transport is rest Sep 12, 2023
@JoeWang1127 JoeWang1127 changed the title bugfix: skip generating grpc-* directory if transport is rest fix: skip generating grpc-* directory if transport is rest Sep 12, 2023
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Sep 12, 2023
@JoeWang1127 JoeWang1127 marked this pull request as ready for review September 13, 2023 01:02
@JoeWang1127 JoeWang1127 requested a review from a team as a code owner September 13, 2023 01:02
@JoeWang1127
Copy link
Collaborator Author

Test locally with google compute, a rest only library.

Will add more integration tests in another PR.

@meltsufin
Copy link
Member

@JoeWang1127 There seems to be a lot more going on here than just "skip generating grpc-* directory if transport is rest". Can you explain more what you're trying to do in this PR or split it into multiple? It will be easier to review.

@JoeWang1127
Copy link
Collaborator Author

@JoeWang1127 There seems to be a lot more going on here than just "skip generating grpc-* directory if transport is rest". Can you explain more what you're trying to do in this PR or split it into multiple? It will be easier to review.

I added a PR description. The refactor happens here because the utilitiy functions that parsing transport, rest_numeric_enums and include_samples are similar.

@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2023

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2023

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2023

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@JoeWang1127 JoeWang1127 merged commit 9c0316b into main Sep 14, 2023
41 of 43 checks passed
@JoeWang1127 JoeWang1127 deleted the chore/test-multi-libraries branch September 14, 2023 00:18
@JoeWang1127 JoeWang1127 changed the title fix: skip generating grpc-* directory if transport is rest feat: skip generating grpc-* directory if transport is rest Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The generated google compute library has grpc-* directory when transport is rest
3 participants