Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: filter out *gapic.legacy.yaml when parsing java_gapic_opts #2015

Merged
merged 1 commit into from Sep 20, 2023
Merged

feat: filter out *gapic.legacy.yaml when parsing java_gapic_opts #2015

merged 1 commit into from Sep 20, 2023

Conversation

JoeWang1127
Copy link
Collaborator

Fixes #2014 ☕️

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Sep 20, 2023
@JoeWang1127
Copy link
Collaborator Author

Test locally with proto_path_list:

google/cloud/videointelligence/v1 google-cloud-videointelligence-v1-java

@JoeWang1127 JoeWang1127 marked this pull request as ready for review September 20, 2023 15:44
@JoeWang1127 JoeWang1127 requested a review from a team as a code owner September 20, 2023 15:44
@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2023

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2023

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2023

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@JoeWang1127 JoeWang1127 added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 20, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 20, 2023
@JoeWang1127 JoeWang1127 merged commit 1ad5ec0 into main Sep 20, 2023
43 checks passed
@JoeWang1127 JoeWang1127 deleted the feat/filter-out-legacy-yaml branch September 20, 2023 17:16
@release-please release-please bot mentioned this pull request Sep 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meltsufin meltsufin meltsufin approved these changes

@diegomarquezp diegomarquezp diegomarquezp approved these changes

@blakeli0 blakeli0 Awaiting requested review from blakeli0

Assignees
No one assigned
Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter *.legacy.yaml when parsing java_gapic_opt from proto_path
3 participants
@JoeWang1127 @meltsufin @diegomarquezp