Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: filter out *gapic.legacy.yaml when parsing java_gapic_opts #2015

Merged
merged 1 commit into from Sep 20, 2023
Merged

feat: filter out *gapic.legacy.yaml when parsing java_gapic_opts #2015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions library_generation/test/resources/gapic_options/example_gapic.legacy.yaml
View file
Open in desktop
@@ -0,0 +1 @@
# this file is only used in testing `get_gapic_opts` in utilities.sh
1 change: 1 addition & 0 deletions library_generation/test/resources/gapic_options/example_gapic_legacy.yaml
View file
Open in desktop
@@ -0,0 +1 @@
# this file is only used in testing `get_gapic_opts` in utilities.sh
2 changes: 1 addition & 1 deletion library_generation/utilities.sh
View file
Open in desktop
Expand Up @@ -59,7 +59,7 @@ get_gapic_opts() {
gapic_config="gapic-config=${gapic_config},"
fi
grpc_service_config=$(find "${proto_path}" -type f -name "*service_config.json")
api_service_config=$(find "${proto_path}" -maxdepth 1 -type f \( -name "*.yaml" ! -name "*gapic.yaml" \))
api_service_config=$(find "${proto_path}" -maxdepth 1 -type f \( -name "*.yaml" ! -name "*gapic*.yaml" \))
if [ "${rest_numeric_enums}" == "true" ]; then
rest_numeric_enums="rest-numeric-enums,"
else
Expand Down