Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Structs mapper utility #2278

Merged
merged 4 commits into from Dec 5, 2023
Merged

feat: Structs mapper utility #2278

merged 4 commits into from Dec 5, 2023

Conversation

kolea2
Copy link
Contributor

@kolea2 kolea2 commented Nov 30, 2023

Originally implemented in https://github.com/googleapis/java-logging/blob/d3f897c26b5b55436d2212a0d7452940f15c413f/google-cloud-logging/src/main/java/com/google/cloud/logging/Structs.java, this is a common utility that other projects can benefit from.

Test is from: https://github.com/googleapis/java-logging/blob/d3f897c26b5b55436d2212a0d7452940f15c413f/google-cloud-logging/src/test/java/com/google/cloud/logging/StructsTest.java

The only difference between the java-logging implementation and this is that builder and class methods in Structs.java have been made public.

@kolea2 kolea2 requested a review from a team as a code owner November 30, 2023 16:21
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Nov 30, 2023
@kolea2 kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 30, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 30, 2023
@blakeli0
Copy link
Collaborator

blakeli0 commented Dec 1, 2023

@kolea2 Can you please create an issue for tracking purpose?

Also can I understand more about your use case? Do you need all of the functionality from this class or only a subset of it? Is there any other ways to do it?
In general, it's good to have utils in the common layer, but we also want to be careful as anything we put in common layers will be exposed to all services. So it's much less flexible to make changes in the future and have to be supported (almost)forever.

@kolea2 kolea2 mentioned this pull request Dec 4, 2023
@kolea2 kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 4, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 4, 2023
Copy link

sonarcloud bot commented Dec 4, 2023

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

89.9% 89.9% Coverage
0.0% 0.0% Duplication

Copy link

sonarcloud bot commented Dec 4, 2023

[java_showcase_integration_tests] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@kolea2 kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 5, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants