Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: OS detection and single-folder output for hermetic build scripts #1982

Closed
wants to merge 6 commits into from
Closed

wip: OS detection and single-folder output for hermetic build scripts #1982

wants to merge 6 commits into from

Conversation

diegomarquezp
Copy link
Contributor

@diegomarquezp diegomarquezp commented Sep 13, 2023 •
edited

  • All generated and downloaded files will go to ${script_dir}/output to make cleanup easier
  • OS is now detected and an optional argument

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Sep 13, 2023
@diegomarquezp diegomarquezp added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 13, 2023
@diegomarquezp diegomarquezp changed the title feat: OS detection and single-folder output for hermetic build scripts wip: OS detection and single-folder output for hermetic build scripts Sep 13, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2023

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2023

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2023

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@JoeWang1127
Copy link
Collaborator

FYI, I also add an OS detection function in https://github.com/googleapis/sdk-platform-java/pull/1979/files#diff-635d3a32a75acce3db49f8c36f88f5262ccd9af7dbb1b43abee42451d4a26c87R325

@diegomarquezp
Copy link
Contributor Author

Separating this into two PRs

#1987
(OS detection yet to come)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diegomarquezp @JoeWang1127