Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use Junit5 in api-common #2779

Merged
merged 13 commits into from
May 17, 2024
Merged

test: use Junit5 in api-common #2779

merged 13 commits into from
May 17, 2024

Conversation

alicejli
Copy link
Contributor

Fixes #2727 ☕️

@alicejli alicejli requested a review from a team as a code owner May 16, 2024 15:27
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label May 16, 2024
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@lqiu96 lqiu96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alicejli alicejli merged commit 1ade786 into main May 17, 2024
47 checks passed
@alicejli alicejli deleted the migrateApiCommonJavaJunit5 branch May 17, 2024 13:30
lqiu96 pushed a commit that referenced this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Junit 4 to Junit 5: api-common-java
3 participants