Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: exclude google-api-client-bom from google api dependencies group #2781

Merged
merged 1 commit into from
May 16, 2024

Conversation

JoeWang1127
Copy link
Collaborator

In this PR:

  • Exclude google-api-client-bom from google api dependencies group

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label May 16, 2024
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@JoeWang1127 JoeWang1127 marked this pull request as ready for review May 16, 2024 18:06
@JoeWang1127 JoeWang1127 requested a review from a team as a code owner May 16, 2024 18:06
@JoeWang1127 JoeWang1127 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 16, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 16, 2024
@blakeli0
Copy link
Collaborator

It only excludes google-api-client from grouping, but does not exclude it from renovate bot update right?

@JoeWang1127
Copy link
Collaborator Author

It only excludes google-api-client from grouping, but does not exclude it from renovate bot update right?

Yes, com.google.api-client:google-api-client-bom still gets updates from renovate.

@JoeWang1127 JoeWang1127 merged commit c4ce140 into main May 16, 2024
48 checks passed
@JoeWang1127 JoeWang1127 deleted the chore/exclude-api-client-bom branch May 16, 2024 18:43
lqiu96 pushed a commit that referenced this pull request May 16, 2024
…roup (#2781)

In this PR:
- Exclude `google-api-client-bom` from google api dependencies group
lqiu96 pushed a commit that referenced this pull request May 22, 2024
…roup (#2781)

In this PR:
- Exclude `google-api-client-bom` from google api dependencies group
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants