Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(python): install google-api-core for python generator #916

Merged
merged 3 commits into from Jan 25, 2021

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Jan 22, 2021

Temporary fix for the broken python autosynth builds. (googleapis/gapic-generator#3334)

The python microgenerator requires google-api-core. Because of a package import issue google-api-core is not being installed and Python autosynth jobs are failing. The workaround is to install the python generator requirements on the Python version that will be used by bazel.

From @vam-google:

it is a really sophisticated python package import issue, which arises when multiple https://packaging.python.org/guides/packaging-namespace-packages/#pkg-resources-style-namespace-packages packages with the same namespace are used from bazel, and unfortunately gogole.api_core and protobuf are like that (with google namespace)

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 22, 2021
@@ -1,4 +1,3 @@
# Pin to less than 49.6.0 as a workaround for https://github.com/pypa/setuptools/issues/2353
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the comment as it looked outdated (setuptools is pinned to 50.3.2)

Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@busunkim96 busunkim96 merged commit 845a4a0 into master Jan 25, 2021
@busunkim96 busunkim96 deleted the fix-python-synth branch January 25, 2021 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants