fix: git thought some php files were binary and refused to diff #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass the --binary flag to git diff so it can diff files no matter if they're binary or text. Fixes googleapis#918
google-cla
bot
added
the
cla: yes
bshaffer
approved these changes
Jan 27, 2021
About 1/3 of the APIs are still failing due to binary files.
dwsupplee
approved these changes
Jan 28, 2021
SurferJeffAtGoogle
force-pushed
the
fixx-php
branch
from
bfc7b99
to
e46e39d
Compare
chingor13
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the --binary flag to git diff so it can diff files no matter if they're binary or text.
Fixes #918