Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(python): install google-api-core on default python #929

Closed
wants to merge 3 commits into from
Closed

build(python): install google-api-core on default python #929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5137b3a
fix: adding google-api-core above protobuf
busunkim96 Jan 28, 2021
dc71665
fix: install api-core on python
busunkim96 Jan 28, 2021
b4d200d
fix: fix bad protobuf version
busunkim96 Jan 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions .kokoro-autosynth/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,14 @@ export GITHUB_TOKEN=$(cat ${KOKORO_KEYSTORE_DIR}/73713_yoshi-automation-github-k
echo "https://${GITHUB_TOKEN}:@github.com" >> ~/.git-credentials
git config --global credential.helper 'store --file ~/.git-credentials'

# https://github.com/googleapis/gapic-generator/issues/3334
# temporarily install google-api-core for gapic-generator-python
# Bazel should install this, but there is currently a bug
# that causes the package to be skipped.
# This is intentionally installed *outside* the virtualenv
# so Bazel can find and use it.
python3 -m pip install google-api-core==1.25.1 protobuf==3.14.0

python3 -m venv env
source env/bin/activate
python3 -m pip install --upgrade --quiet -r requirements.txt
Expand Down
6 changes: 0 additions & 6 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,6 @@ deprecation
protobuf==3.14.0
watchdog

# https://github.com/googleapis/gapic-generator/issues/3334
# temporarily install google-api-core for gapic-generator-python
# Bazel should install this, but there is currently a bug
# that causes the package to be skipped
google-api-core==1.25.1

# some java processing requires xml handling
lxml

Expand Down