Feature/recipes precache and normalize #2718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Takes an array of items and a Workbox Strategy and warms the strategy’s cache with those items at install. Useful for getting specific items into cache but allowing them to be updated outside of the Service Worker install cycle
Give users of page/image/resource recipes the ability to warm those caches using warmStrategyCache functionality. Also allows them to include plugins if desired (for instance, to normalize URLs coming into the cache)
While precache will still work, and that will be tried first, the files will be saved in a workbox-offline-fallbacks cache and the cache will try to be retrieved from there if precache fails.
|
I'm not sure what the error in the Mac test suite is, and why the Windows one didn't fail. If someone can point me to what I need to fix I'd be more than happy to fix it. |
jeffposnick
suggested changes
Jan 8, 2021
| */ | ||
| function warmStrategyCache(options: WarmStrategyCacheOptions): void { | ||
| self.addEventListener('install', event => { | ||
| const warm = options.paths.map(path => options.strategy.handleAll({ |
There was a problem hiding this comment.
I think done (or donePromises) would be a more descriptive variable name than warm, especially since it's not entirely obvious from reading the code that the [1] index represents a done promise.
| import './_version.js'; | ||
|
|
||
| export interface WarmStrategyCacheOptions { | ||
| paths: Array<string>; |
There was a problem hiding this comment.
Can you switch from calling this paths to urls?
(As far as I can tell, you should be able to pass in any absolute or relative URL inside this array, right?)
Co-authored-by: Jeffrey Posnick <jeffy@google.com>
Improves clarity of each, pre PR review request
4 tasks
|
@jeffposnick Looks like test are passing now. Here's the Workbox Recipes docs update to go along w/this |
jeffposnick
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @jeffposnick @philipwalton
warmStrategyCache, which takes an array of paths and a Workbox strategy and warms that strategy's cache with those paths at service worker install time.warmCacheoption to page, image, and static resource recipes to allow users to warm those cachespluginsoption to page, image, and static resource recipes to allow users to pass additional plugins to those recipes, allowing a user, for instance, to add a URL normalization plugin to the page recipe