dependency: bump github.com/grpc-ecosystem/grpc-gateway/v2 from v2.15.0 to v2.17.1 #3366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….0 to v2.17.1 Signed-off-by: aimuz <mr.imuz@gmail.com>
|
Build Failed 😱 Build Id: 030f1196-2292-475c-a6ff-98534f222b25 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Signed-off-by: aimuz <mr.imuz@gmail.com>
|
Build Succeeded 👏 Build Id: b946a4b8-bb45-4678-b8fe-8cc5efdc3d58 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
🤔 why does a dependency bump in released Agones affect any of the examples? |
aimuz
commented
Sep 9, 2023
| replace agones.dev/agones => ../../ |
There was a problem hiding this comment.
@markmandel Here's a replace that should answer your question.
There was a problem hiding this comment.
replace will try to invalidate the versioning constraints of require, and the contents of replace will always prevail.
aimuz
commented
Sep 9, 2023
| google.golang.org/genproto/googleapis/api v0.0.0-20230822172742-b8732ec3820d // indirect | ||
| google.golang.org/genproto/googleapis/rpc v0.0.0-20230822172742-b8732ec3820d // indirect | ||
| google.golang.org/grpc v1.57.0 // indirect | ||
| google.golang.org/protobuf v1.31.0 // indirect | ||
| ) | ||
|
|
||
| replace agones.dev/agones => ../../ |
There was a problem hiding this comment.
And here, all instances of go.mod exist replace
markmandel
approved these changes
Sep 12, 2023
| @@ -238,9 +238,6 @@ | |||
| "properties": { | |||
| "result": { | |||
| "$ref": "#/definitions/sdkGameServer" | |||
| }, | |||
There was a problem hiding this comment.
I wonder why this was here in the first place? 🤔
There was a problem hiding this comment.
I'll look into this.
There was a problem hiding this comment.
The option disable_default_errors exists, and it doesn't look like it should be there.
https://github.com/googleforgames/agones/blob/main/build/build-sdk-images/go/gen.sh#L56
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aimuz, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
Build Succeeded 👏 Build Id: 065de650-22b4-4229-9c86-f8547af52d4e The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
zmerlynn
added a commit
to zmerlynn/agones
that referenced
this pull request
Sep 19, 2023
* Adds version detection in the GKE cloud product. When the version is >=1.27, we enable support for Extended Duration (ED) pods. * ED pods have the same UI as disabling Autopilot on GKE Standard [1]: annotate with `cluster-autoscaler.kubernetes.io/safe-to-evict=false` and your pod is protected from eviction. However, Autopilot handles node upgrades specially and just autoscales new nodes at new versions, so the concept of "safe to evict on upgrade" is unnecessary. Since we can support the concept and do nothing really special, do so: We pull out the "generic" implementation of SetEviction into cloudproduct/eviction and call that. Documentation changes to come in a further PR. [1] https://cloud.google.com/kubernetes-engine/docs/how-to/extended-duration-pods Towards googleforgames#3366
zmerlynn
added a commit
to zmerlynn/agones
that referenced
this pull request
Sep 19, 2023
* Adds version detection in the GKE cloud product. When the version is >=1.27, we enable support for Extended Duration (ED) pods. * ED pods have the same UI as disabling Autopilot on GKE Standard [1]: annotate with `cluster-autoscaler.kubernetes.io/safe-to-evict=false` and your pod is protected from eviction. However, Autopilot handles node upgrades specially and just autoscales new nodes at new versions, so the concept of "safe to evict on upgrade" is unnecessary. Since we can support the concept and do nothing really special, do so: We pull out the "generic" implementation of SetEviction into cloudproduct/eviction and call that. Documentation changes to come in a further PR. [1] https://cloud.google.com/kubernetes-engine/docs/how-to/extended-duration-pods Towards googleforgames#3366
Kalaiselvi84
added
kind/cleanup
zmerlynn
added a commit
to zmerlynn/agones
that referenced
this pull request
Dec 5, 2023
… gate Introduces Extended Duration Pod support for Autopilot under feature gate "GKEAutopilotExtendedDurationPods". This feature has some rough edges with Agones on Autopilot 1.27, so I'm introducing this as a dev feature gate until we sort everything out. ED pods have the same UI as disabling Autopilot on GKE Standard [1]: annotate with `cluster-autoscaler.kubernetes.io/safe-to-evict=false` and your pod is protected from eviction. However, Autopilot handles node upgrades specially and just autoscales new nodes at new versions, so the concept of "safe to evict on upgrade" is unnecessary. Since we can support the concept and do nothing really special, do so: We pull out the "generic" implementation of SetEviction into cloudproduct/eviction and call that. [1] https://cloud.google.com/kubernetes-engine/docs/how-to/extended-duration-pods Towards googleforgames#3366
zmerlynn
added a commit
to zmerlynn/agones
that referenced
this pull request
Dec 5, 2023
… gate Introduces Extended Duration Pod support for Autopilot under feature gate "GKEAutopilotExtendedDurationPods". This feature has some rough edges with Agones on Autopilot 1.27, so I'm introducing this as a dev feature gate until we sort everything out. ED pods have the same UI as disabling Autopilot on GKE Standard [1]: annotate with `cluster-autoscaler.kubernetes.io/safe-to-evict=false` and your pod is protected from eviction. However, Autopilot handles node upgrades specially and just autoscales new nodes at new versions, so the concept of "safe to evict on upgrade" is unnecessary. Since we can support the concept and do nothing really special, do so: We pull out the "generic" implementation of SetEviction into cloudproduct/eviction and call that. [1] https://cloud.google.com/kubernetes-engine/docs/how-to/extended-duration-pods Towards googleforgames#3366
zmerlynn
added a commit
to zmerlynn/agones
that referenced
this pull request
Dec 6, 2023
… gate Introduces Extended Duration Pod support for Autopilot under feature gate "GKEAutopilotExtendedDurationPods". This feature has some rough edges with Agones on Autopilot 1.27, so I'm introducing this as a dev feature gate until we sort everything out. ED pods have the same UI as disabling Autopilot on GKE Standard [1]: annotate with `cluster-autoscaler.kubernetes.io/safe-to-evict=false` and your pod is protected from eviction. However, Autopilot handles node upgrades specially and just autoscales new nodes at new versions, so the concept of "safe to evict on upgrade" is unnecessary. Since we can support the concept and do nothing really special, do so: We pull out the "generic" implementation of SetEviction into cloudproduct/eviction and call that. [1] https://cloud.google.com/kubernetes-engine/docs/how-to/extended-duration-pods Towards googleforgames#3366
zmerlynn
added a commit
that referenced
this pull request
Dec 8, 2023
… gate (#3387) Introduces Extended Duration Pod support for Autopilot under feature gate "GKEAutopilotExtendedDurationPods". This feature has some rough edges with Agones on Autopilot 1.27, so I'm introducing this as a dev feature gate until we sort everything out. ED pods have the same UI as disabling Autopilot on GKE Standard [1]: annotate with `cluster-autoscaler.kubernetes.io/safe-to-evict=false` and your pod is protected from eviction. However, Autopilot handles node upgrades specially and just autoscales new nodes at new versions, so the concept of "safe to evict on upgrade" is unnecessary. Since we can support the concept and do nothing really special, do so: We pull out the "generic" implementation of SetEviction into cloudproduct/eviction and call that. [1] https://cloud.google.com/kubernetes-engine/docs/how-to/extended-duration-pods Towards #3366
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: aimuz mr.imuz@gmail.com
What type of PR is this?
What this PR does / Why we need it:
Which issue(s) this PR fixes:
Closes #
Special notes for your reviewer:
ref: googleapis/go-genproto#1015