List stores by alphabetical order if location is not given in the request #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you pull #104 which temporarily fixed the server test ordering issue? |
cszqwe
requested changes
Jun 24, 2020
This was
linked to
issues
Jun 24, 2020
devYaoYH
reviewed
Jun 24, 2020
| @@ -38,11 +38,6 @@ app.use((err, req, res, next) => { | |||
| app.use(compression()); | |||
|
|
|||
| const server = app.listen(PORT, function () { | |||
| console.log(config.ENV); | |||
| if (config.ENV === config.TEST) { | |||
There was a problem hiding this comment.
To clarify: I intended this to be here for testing with yarn start_test which is set up to use the emulated firestore DB rather than our live DB. But maybe there is a better place to put this initialization code on server startup.
cszqwe
approved these changes
Jun 25, 2020
BhavyaLight
approved these changes
Jun 25, 2020
redhoteggplant
added a commit
to redhoteggplant/scan-and-go
that referenced
this pull request
Jun 30, 2020
List stores by alphabetical order if location is not given in the request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a query limit for performance, but maybe this should be removed?
Other options for fallbacks if user doesn't share their location:
Unresolved: jest continues to detect open handles, as described in greater detail in #100