Fixed dependency issues between JSDOM and betterdocs #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st piece of documentation for IconSearchBar
devYaoYH
changed the title
BhavyaLight
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
[same issue we are facing] jsdom/jsdom#2961
[identified cause] https://github.com/microsoft/TypeScript/blob/27616dd523279a5d699d2154edb4de6abc8234ad/src/services/globalThisShim.ts#L21
Upgraded typescript doesn't play well with node10 and JSDOM which jest uses to mock browser
Solution: Freeze typescript version to 3.7.5 that works with both JSDOM and is the minimum version required for betterdocs
Conclusion: In some version of typescript
3.8.x+ added a globalThis redefinition? that breaks JSDOM dependency injest-environment-jsdom-sixteenwe are using for testing (original out-of-the-box typescript dependency for CRA was set to~3.7.2which in yarn syntax means we look for minimum >= 3.7.2 but allow upgrades up to the major version so < 4.0.0)