CI: Run vite build only after type-check has passed #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nighca
reviewed
Mar 1, 2024
| @@ -5,7 +5,7 @@ | |||
| "type": "module", | |||
| "scripts": { | |||
| "dev": "vite", | |||
| "build": "vite build", | |||
| "build": "vue-tsc --build --force && vite build", | |||
There was a problem hiding this comment.
这个做法（--build --force）应该并不是常规的做法？这里说明下需要这么做的原因？
There was a problem hiding this comment.
这个是和type-check一样的命令，官方vue模板就是这么做类型检查的
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
vuejs/create-vue#274 (comment)
看起来官方自己加得也有点糊涂，先链接在这吧
nighca
approved these changes
Mar 1, 2024
qing-wq
pushed a commit
to qing-wq/builder
that referenced
this pull request
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.