Alps 904 - Video quality change #73
Conversation
|
Not related, but I can take a look at it and push it inside this PR. Note that there are also problems with the VideoControls plugin. |
|
You're right @aberthet-gpsw I can reproduce the black screen issue on my mac/chrome with the master branch. I don't remember that happened on my Unbuntu desktop I will have to test again on Ubuntu to have a clear view of the bug. Have to test Firefox too ! |
|
@aberthet-gpsw Please if you want to have a look on this issue, come see me if you can't reproduce. 😁 |
HTMLVideoElement wasn't always ready and thus null. We tried to remove some EventListener of something null, so it crashed. It is not the case anymore, as a check on the HTMLVideoElement (either null or undefined) is done.
aberthet-gpsw
force-pushed
the
alps-904-video-quality-change
branch
from
14c7c94
to
be6939f
Compare
|
|
- first one was when you made a quick request in the quality change of the video, the video would crash - second one was when you made a quick request in the quality change of the video, when reaching the end the video would crash, even if resuming was set to true
|
So I'm stopping here my changes, as I can't go further. The blocking element here is the I propose to let it as it is, given that this bug shouldn't be reproduced by the vast majority of users. And as we plan to change in the future the inner workings of playable object (Video, Sound etc...), we may fix it at this moment. |
When requesting quickly a change in the quality of a video, the HTMLVideoElement wasn't always ready and thus null. We tried to remove some EventListener of something null, so it crashed. It is not the case anymore, as a check on the HTMLVideoElement (either null or undefined) is done.