Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add separate method for file/directory metadata modifcation #800

Open
wants to merge 40 commits into
base: master
Choose a base branch
from
Open

Add separate method for file/directory metadata modifcation #800

wants to merge 40 commits into from

Conversation

GreatBahram
Copy link

Hi there,

As we discussed here #260, I tried to solve the problem using two new events for inotify, kqueue, and fsevents2 backends. So far, I've found no solution for the windows, as in this document describes it does not have an action for this purpose.

@GreatBahram
Change the test github workflow
151f651 
To be able to run it manually, currently it only works when you send a pull_request
@GreatBahram
add on: pull_request workflow statement:
dc366d6 
apparently, it is OK to have both on [pull_request, workflow_dispatch]
@GreatBahram
WIP: fix two more test cases and make sure they work correctly on bsd…
1ca76cb 
… and darwin kernels
@GreatBahram
add test cases for file_attrib and dir_attrib
c3dc00f
@GreatBahram
add chmod function into shell module and add test cases to test it wo…
165a6f4 
…rks properly with FileAttrib and DirAttrib events
@GreatBahram
I think I fixed the nested tese case
b710851
@GreatBahram
Make flake8 happier than ever
424cb47
@GreatBahram
WIP: Disable the lifecycle test case
58b514f
@GreatBahram
Update fsevents module: this should be tested more than any other mod…
677ac9f 
…ules
@GreatBahram
bugfix test case: test_modify on BSD
467b1e2
@GreatBahram
return str repsentation instead of Pathlib object
5e94d19
@GreatBahram
make the equality method more strict
60415b7
@GreatBahram
run test work for pull_request and when user asks for it
9d0e19c
@GreatBahram
bugfix: document
dfb27d6
@GreatBahram
Copy link
Author

Hi @BoboTiG,

Could you approve my workflows, please?

I changed the fsevents and fsevents2 modules, but I'm still unsure of them. The GitHub actions is very primitive; I could not get any guarantee out of it. But for inofity and kqueue, I tested them manually on Linux and Freebsd.

I’m eager to receive your feedback.

@GreatBahram
Copy link
Author

The pipeline gives a bizarre error message. Do you know what the reason is?

OSError: [Errno 9] Bad file descriptor

@BoboTiG BoboTiG mentioned this pull request Jan 4, 2023
Closed
BoboTiG
BoboTiG reviewed Mar 18, 2023
View reviewed changes
src/watchdog/events.py Outdated Show resolved Hide resolved
src/watchdog/events.py Outdated Show resolved Hide resolved
src/watchdog/events.py Outdated Show resolved Hide resolved
src/watchdog/observers/fsevents.py Outdated Show resolved Hide resolved
src/watchdog/observers/fsevents.py Outdated Show resolved Hide resolved
tests/test_emitter.py Outdated Show resolved Hide resolved
tests/test_emitter.py Outdated Show resolved Hide resolved
tests/test_emitter.py Outdated Show resolved Hide resolved
tests/test_emitter.py Outdated Show resolved Hide resolved
tests/test_emitter.py Outdated Show resolved Hide resolved
@BoboTiG
Copy link
Collaborator

BoboTiG commented Mar 18, 2023 •
edited

@GreatBahram I fixed conflicts, and rebased from master. Would you be able to double check I didn't alter what you've done in tests + fix linting/mypy issues 🙏🏻 ?

@mmguero
Copy link

mmguero commented Apr 6, 2023

Glad to see this PR is still alive, I'd love to see this get pulled.

@mmguero mmguero mentioned this pull request Apr 6, 2023
Closed
BoboTiG
BoboTiG reviewed Apr 22, 2023
View reviewed changes
tests/shell.py Outdated Show resolved Hide resolved
src/watchdog/events.py Show resolved Hide resolved
src/watchdog/events.py Show resolved Hide resolved
BoboTiG
BoboTiG reviewed Apr 22, 2023
View reviewed changes
src/watchdog/observers/fsevents.py Outdated Show resolved Hide resolved
src/watchdog/observers/fsevents.py Outdated Show resolved Hide resolved
src/watchdog/observers/fsevents.py Outdated Show resolved Hide resolved
@BoboTiG
Copy link
Collaborator

BoboTiG commented Apr 22, 2023

Several Mac, and Windows, tests are failing. I'l try to fix them later. I would like to have that PR merged for the upcoming version.

BoboTiG
BoboTiG reviewed Apr 24, 2023
View reviewed changes
tests/test_fsevents.py Outdated Show resolved Hide resolved
BoboTiG
BoboTiG reviewed Apr 24, 2023
View reviewed changes
tests/test_emitter.py Outdated Show resolved Hide resolved
BoboTiG
BoboTiG reviewed Apr 24, 2023
View reviewed changes
tests/utils.py Show resolved Hide resolved
tests/test_emitter.py Outdated Show resolved Hide resolved
tests/utils.py Outdated Show resolved Hide resolved
@BoboTiG
Copy link
Collaborator

BoboTiG commented Apr 24, 2023

A few remaining macOS tests to fix, and we will be good to merge.

@BoboTiG
Copy link
Collaborator

BoboTiG commented May 14, 2023

I finally have a Mac machine, it will be easier to fix those tests. I'll try to get it done "quickly".

@sevenrats sevenrats mentioned this pull request May 31, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoboTiG BoboTiG BoboTiG left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GreatBahram @BoboTiG @mmguero