Skip to content

Commit

Permalink
refactor(brew): use cases.Title instead of strings.Title
Browse files Browse the repository at this point in the history
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
  • Loading branch information
caarlos0 committed Nov 30, 2023
1 parent c567f15 commit 6f598dc
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 7 deletions.
7 changes: 5 additions & 2 deletions internal/pipe/brew/brew.go
Expand Up @@ -23,6 +23,8 @@ import (
"github.com/goreleaser/goreleaser/internal/tmpl"
"github.com/goreleaser/goreleaser/pkg/config"
"github.com/goreleaser/goreleaser/pkg/context"
"golang.org/x/text/cases"
"golang.org/x/text/language"
)

const brewConfigExtra = "BrewConfig"
Expand Down Expand Up @@ -471,6 +473,7 @@ func formulaNameFor(name string) string {
name = strings.ReplaceAll(name, "-", " ")
name = strings.ReplaceAll(name, "_", " ")
name = strings.ReplaceAll(name, ".", "")
name = strings.ReplaceAll(name, "@", "AT")
return strings.ReplaceAll(strings.Title(name), " ", "") // nolint:staticcheck
name = cases.Title(language.English).String(name)
name = strings.ReplaceAll(name, " ", "")
return strings.ReplaceAll(name, "@", "AT")
}
10 changes: 5 additions & 5 deletions internal/pipe/brew/brew_test.go
Expand Up @@ -27,23 +27,23 @@ func TestDescription(t *testing.T) {
}

func TestNameWithDash(t *testing.T) {
require.Equal(t, formulaNameFor("some-binary"), "SomeBinary")
require.Equal(t, "SomeBinary", formulaNameFor("some-binary"))
}

func TestNameWithUnderline(t *testing.T) {
require.Equal(t, formulaNameFor("some_binary"), "SomeBinary")
require.Equal(t, "SomeBinary", formulaNameFor("some_binary"))
}

func TestNameWithDots(t *testing.T) {
require.Equal(t, formulaNameFor("binaryv0.0.0"), "Binaryv000")
require.Equal(t, "Binaryv000", formulaNameFor("binaryv0.0.0"))
}

func TestNameWithAT(t *testing.T) {
require.Equal(t, formulaNameFor("some_binary@1"), "SomeBinaryAT1")
require.Equal(t, "SomeBinaryAT1", formulaNameFor("some_binary@1"))
}

func TestSimpleName(t *testing.T) {
require.Equal(t, formulaNameFor("binary"), "Binary")
require.Equal(t, "Binary", formulaNameFor("binary"))
}

var defaultTemplateData = templateData{
Expand Down

0 comments on commit 6f598dc

Please sign in to comment.