feat: add windows to default builds (#3581)

Resolves #3579 Signed-off-by: jolheiser <john.olheiser@gmail.com>
goreleaser · Nov 24, 2022 · b665685 · b665685
1 parent f3f1c08
commit b665685
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 4 deletions.
diff --git a/internal/builders/golang/build.go b/internal/builders/golang/build.go
@@ -53,7 +53,7 @@ func (*Builder) WithDefaults(build config.Build) (config.Build, error) {
 	}
 	if len(build.Targets) == 0 {
 		if len(build.Goos) == 0 {
-			build.Goos = []string{"linux", "darwin"}
+			build.Goos = []string{"linux", "darwin", "windows"}
 		}
 		if len(build.Goarch) == 0 {
 			build.Goarch = []string{"amd64", "arm64", "386"}

diff --git a/internal/builders/golang/build_test.go b/internal/builders/golang/build_test.go
@@ -77,6 +77,9 @@ func TestWithDefaults(t *testing.T) {
 				"linux_arm64",
 				"darwin_amd64_v1",
 				"darwin_arm64",
+				"windows_amd64_v1",
+				"windows_arm64",
+				"windows_386",
 			},
 			goBinary: "go",
 		},
@@ -167,6 +170,9 @@ func TestWithDefaults(t *testing.T) {
 				"linux_arm64",
 				"darwin_amd64_v1",
 				"darwin_arm64",
+				"windows_amd64_v1",
+				"windows_arm64",
+				"windows_386",
 			},
 			goBinary: "go",
 		},
@@ -182,6 +188,9 @@ func TestWithDefaults(t *testing.T) {
 				"linux_arm64",
 				"darwin_amd64_v1",
 				"darwin_arm64",
+				"windows_amd64_v1",
+				"windows_arm64",
+				"windows_386",
 			},
 			goBinary: "go",
 		},

diff --git a/internal/pipe/build/build_test.go b/internal/pipe/build/build_test.go
@@ -275,7 +275,7 @@ func TestDefaultEmptyBuild(t *testing.T) {
 	require.Equal(t, ctx.Config.ProjectName, build.Binary)
 	require.Equal(t, ".", build.Dir)
 	require.Equal(t, ".", build.Main)
-	require.Equal(t, []string{"linux", "darwin"}, build.Goos)
+	require.Equal(t, []string{"linux", "darwin", "windows"}, build.Goos)
 	require.Equal(t, []string{"amd64", "arm64", "386"}, build.Goarch)
 	require.Equal(t, []string{"6"}, build.Goarm)
 	require.Equal(t, []string{"hardfloat"}, build.Gomips)
@@ -373,7 +373,7 @@ func TestDefaultPartialBuilds(t *testing.T) {
 		require.Equal(t, "foo", build.Binary)
 		require.Equal(t, ".", build.Main)
 		require.Equal(t, "baz", build.Dir)
-		require.Equal(t, []string{"linux", "darwin"}, build.Goos)
+		require.Equal(t, []string{"linux", "darwin", "windows"}, build.Goos)
 		require.Equal(t, []string{"386"}, build.Goarch)
 		require.Equal(t, []string{"6"}, build.Goarm)
 		require.Len(t, build.Ldflags, 1)

diff --git a/www/docs/customization/build.md b/www/docs/customization/build.md
@@ -77,7 +77,7 @@ builds:
 
     # GOOS list to build for.
     # For more info refer to: https://golang.org/doc/install/source#environment
-    # Defaults are darwin and linux.
+    # Defaults are darwin, linux, and windows.
     goos:
       - freebsd
       - windows