-
-
Notifications
You must be signed in to change notification settings - Fork 910
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: prevent having whitespaces in artifact names (#4515)
refs #4513 this does not prevent the `dist` filepath to have spaces in it, although that's likely less of an issue, but it will remove the spaces from artifact's names. Ideally, we could add a `tmpl.ApplyTrim` (or similar) that applies and trim spaces, and use it everywhere it makes sense (which is likely a lot of places). Doing it on regular `Apply` might break things like release footers/headers, which usually rely on empty lines (although maybe its easier to treat those cases differently then). Anyway, still thinking about it. Opinions are welcome :) --------- Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
- Loading branch information
Showing
3 changed files
with
75 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters