Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: annotate flags so they complete better #3444

Merged
merged 2 commits into from Oct 6, 2022
Merged

fix: annotate flags so they complete better #3444

merged 2 commits into from Oct 6, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Oct 6, 2022

refs withfig/autocomplete#1584

cc/ @fedeci - thanks for the pointers :)
refs #3328

@caarlos0
fix: annotate flags so they complete better
19aef75 
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 added the enhancement New feature or request label Oct 6, 2022
@caarlos0 caarlos0 requested a review from dirien October 6, 2022 00:22
@caarlos0 caarlos0 self-assigned this Oct 6, 2022
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 6, 2022
@caarlos0 caarlos0 mentioned this pull request Oct 6, 2022
Merged
@codecov
Copy link

codecov bot commented Oct 6, 2022 •
edited

Codecov Report

Merging #3444 (902fd13) into main (c6e092a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3444   +/-   ##
=======================================
  Coverage   84.11%   84.12%           
=======================================
  Files         114      114           
  Lines        9217     9220    +3     
=======================================
+ Hits         7753     7756    +3     
  Misses       1188     1188           
  Partials      276      276
Impacted Files Coverage Δ
cmd/build.go 91.30% <100.00%> (+0.06%) ⬆️
cmd/release.go 100.00% <100.00%> (ø)
cmd/schema.go 60.60% <100.00%> (+1.23%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

dirien
dirien reviewed Oct 6, 2022
View reviewed changes
Copy link
Contributor

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I was not sure at the beginning about adding the annotations.

@vercel vercel bot temporarily deployed to Preview October 6, 2022 05:31 Inactive
fedeci
fedeci approved these changes Oct 6, 2022
View reviewed changes
Copy link

@fedeci fedeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@dirien dirien merged commit 6279e1a into main Oct 6, 2022
@dirien dirien deleted the annotate-flags branch October 6, 2022 09:24
@github-actions github-actions bot added this to the v1.12.0 milestone Oct 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dirien dirien dirien approved these changes

@fedeci fedeci fedeci approved these changes

Assignees

@caarlos0 caarlos0

Labels
enhancement New feature or request size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@caarlos0 @dirien @fedeci