New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(goreleaser): update spec #1584
feat(goreleaser): update spec #1584
Conversation
Overviewsrc/goreleaser.ts:Info: |
Hello @caarlos0,
Please add a 👍 as a reaction to this comment to show that you read this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @caarlos0! I am merging this and making some polishing changes! I am leaving some suggestions for the goreleaser codebase hereby in the PR comments (yeah fig autogenerated specs are great to catch possible improvements too)!
src/goreleaser.ts
Outdated
{ | ||
name: ["--config", "-f"], | ||
description: "Load configuration from file", | ||
args: { name: "config" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filepaths is likely missing in the goreleaser codebase:
args: { name: "config" }, | |
args: { name: "config", template: "filepaths" }, |
src/goreleaser.ts
Outdated
name: ["--output", "-o"], | ||
description: | ||
"Copy the binary to the path after the build. Only taken into account when using --single-target and a single id (either with --id or if configuration only has one build)", | ||
args: { name: "output" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here:
args: { name: "output" }, | |
args: { name: "output", template: "filepaths" }, |
src/goreleaser.ts
Outdated
}, | ||
name: ["--output", "-o"], | ||
description: "Where to save the json schema", | ||
args: { name: "output", default: "-" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
args: { name: "output", default: "-" }, | |
args: { name: "output", default: "-", template: "filepaths" }, |
thanks @fedeci , opened goreleaser/goreleaser#3444 which I think should fix this :) |
PR generated automatically from push-to-fig-autocomplete-action.