Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(goreleaser): update spec #1584

Merged
merged 2 commits into from Oct 5, 2022
Merged

feat(goreleaser): update spec #1584

merged 2 commits into from Oct 5, 2022

Conversation

caarlos0
Copy link
Contributor

@caarlos0 caarlos0 commented Oct 5, 2022

PR generated automatically from push-to-fig-autocomplete-action.

@withfig-bot
Copy link
Collaborator

Overview

src/goreleaser.ts:

Info:

@withfig-bot
Copy link
Collaborator

Hello @caarlos0,
thank you very much for creating a Pull Request!
Here is a small checklist to get this PR merged as quickly as possible:

  • Do all subcommands / options which take arguments include the args property (args: {})?
  • Are all options modular? E.g. -a -u -x instead of -aux
  • Have all other checks passed?

Please add a 👍 as a reaction to this comment to show that you read this.

Copy link
Contributor

@fedeci fedeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @caarlos0! I am merging this and making some polishing changes! I am leaving some suggestions for the goreleaser codebase hereby in the PR comments (yeah fig autogenerated specs are great to catch possible improvements too)!

{
name: ["--config", "-f"],
description: "Load configuration from file",
args: { name: "config" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filepaths is likely missing in the goreleaser codebase:

Suggested change
args: { name: "config" },
args: { name: "config", template: "filepaths" },

name: ["--output", "-o"],
description:
"Copy the binary to the path after the build. Only taken into account when using --single-target and a single id (either with --id or if configuration only has one build)",
args: { name: "output" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here:

Suggested change
args: { name: "output" },
args: { name: "output", template: "filepaths" },

},
name: ["--output", "-o"],
description: "Where to save the json schema",
args: { name: "output", default: "-" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
args: { name: "output", default: "-" },
args: { name: "output", default: "-", template: "filepaths" },

@fedeci fedeci merged commit 5e4a83a into withfig:master Oct 5, 2022
@caarlos0 caarlos0 deleted the auto-update/goreleaser/d17554ec-04d3-4ce4-b3e1-76a27b30134f branch October 5, 2022 23:54
@caarlos0
Copy link
Contributor Author

caarlos0 commented Oct 6, 2022

thanks @fedeci , opened goreleaser/goreleaser#3444 which I think should fix this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants