Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: align Homebrew repo handling with Scoop #1649

Merged
merged 1 commit into from Jul 6, 2020

Conversation

radeksimko
Copy link
Member

This change should be practically no-op from functional perspective, however it does introduce 2 deprecations in the brews section:

The following individual GitHub/GitLab sections:

brews:
  -
    github:
      owner: github-owner
      name: homebrew-tap
brews:
  -
    gitlab:
      owner: gitlab-owner
      name: homebrew-tap

are proposed to be deprecated in favour of a single section

brews:
  -
    tap:
      owner: repo-owner
      name: homebrew-tap

which aligns Homebrew with Scoop:

scoop:
  bucket:
    owner: user
    name: scoop-bucket

This better communicates to the end-user what will happen anyway. e.g. previously one could define brews[].gitlab and while providing GitHub token - in which case we'd generate GitHub URLs and still attempt to upload the formula to GitHub (presumably failing to do so).

This makes it more obvious that one cannot publish "cross provider", e.g. release from GitHub repo and publish formula to GitLab tap. I don't think that would be a very common scenario anyway and the user can still set skip_upload: true and upload it themselves.


This was mainly motivated by #1547 and #1643

@vercel
Copy link

vercel bot commented Jul 6, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goreleaser/goreleaser/1km52as10
✅ Preview: https://goreleaser-git-unify-brew-and-scoop.goreleaser.vercel.app

@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 6, 2020
@vercel vercel bot temporarily deployed to Preview July 6, 2020 12:41 Inactive
@radeksimko radeksimko changed the title refactoring: align Homebrew repo handling with Scoop refactor: align Homebrew repo handling with Scoop Jul 6, 2020
@vercel vercel bot temporarily deployed to Preview July 6, 2020 12:49 Inactive
@codecov
Copy link

codecov bot commented Jul 6, 2020

Codecov Report

Merging #1649 into master will decrease coverage by 0.32%.
The diff coverage is 75.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1649      +/-   ##
==========================================
- Coverage   85.32%   85.00%   -0.33%     
==========================================
  Files          70       70              
  Lines        3891     3894       +3     
==========================================
- Hits         3320     3310      -10     
- Misses        467      477      +10     
- Partials      104      107       +3     
Impacted Files Coverage Δ
internal/client/gitea.go 98.13% <0.00%> (-1.87%) ⬇️
pkg/config/config.go 94.44% <ø> (ø)
internal/client/client.go 87.50% <60.00%> (-12.50%) ⬇️
internal/pipe/brew/brew.go 84.00% <65.00%> (-4.24%) ⬇️
internal/pipe/scoop/scoop.go 88.39% <75.00%> (-3.14%) ⬇️
internal/client/github.go 31.66% <100.00%> (+4.23%) ⬆️
internal/client/gitlab.go 14.76% <100.00%> (+2.93%) ⬆️
internal/deprecate/deprecate.go 100.00% <100.00%> (ø)
internal/pipe/defaults/defaults.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 345b917...9182825. Read the comment docs.

@vercel vercel bot temporarily deployed to Preview July 6, 2020 13:00 Inactive
@caarlos0 caarlos0 merged commit 998e377 into master Jul 6, 2020
@caarlos0 caarlos0 deleted the unify-brew-and-scoop branch July 6, 2020 13:48
@caarlos0
Copy link
Member

caarlos0 commented Jul 6, 2020

awesome, thanks! 🙏

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants