New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: align Homebrew repo handling with Scoop #1649
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/goreleaser/goreleaser/1km52as10 |
93f0b65
to
b5cf685
Compare
b5cf685
to
25981d8
Compare
Codecov Report
@@ Coverage Diff @@
## master #1649 +/- ##
==========================================
- Coverage 85.32% 85.00% -0.33%
==========================================
Files 70 70
Lines 3891 3894 +3
==========================================
- Hits 3320 3310 -10
- Misses 467 477 +10
- Partials 104 107 +3
Continue to review full report at Codecov.
|
25981d8
to
9182825
Compare
awesome, thanks! 🙏 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This change should be practically no-op from functional perspective, however it does introduce 2 deprecations in the
brews
section:The following individual GitHub/GitLab sections:
are proposed to be deprecated in favour of a single section
which aligns Homebrew with Scoop:
This better communicates to the end-user what will happen anyway. e.g. previously one could define
brews[].gitlab
and while providing GitHub token - in which case we'd generate GitHub URLs and still attempt to upload the formula to GitHub (presumably failing to do so).This makes it more obvious that one cannot publish "cross provider", e.g. release from GitHub repo and publish formula to GitLab tap. I don't think that would be a very common scenario anyway and the user can still set
skip_upload: true
and upload it themselves.This was mainly motivated by #1547 and #1643