New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improving URLs on linuxbrew #1900
Conversation
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/goreleaser/goreleaser/5ijx0bsqv |
@@ -310,21 +310,21 @@ func dataFor(ctx *context.Context, cfg config.Homebrew, cl client.Client, artifa | |||
result.MacOS = down | |||
} else if artifact.Goos == "linux" { | |||
switch artifact.Goarch { | |||
case "386", "amd64": | |||
if result.Linux.DownloadURL != "" { | |||
case "amd64": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we never include i386 builds, so this part of the switch was useless
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder how soon are we going to need to make a similar change to account for darwin/arm64
(the Apple Silicon) 😄
@@ -4,24 +4,21 @@ class Test < Formula | |||
homepage "https://google.com" | |||
version "0.1.3" | |||
bottle :unneeded | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that extra space was actually useful from grouping perspective.
Once go 1.16 is out I believe 😂 |
Codecov Report
@@ Coverage Diff @@
## master #1900 +/- ##
=======================================
Coverage 81.78% 81.78%
=======================================
Files 73 73
Lines 3827 3827
=======================================
Hits 3130 3130
Misses 573 573
Partials 124 124
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Fixed the golden
files to make the tests green and docs
This reverts commit 51dd8cf.
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
the tests were right to fail, bad sed on my side... reverted your commit... |
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
depends_on :linux
if only linux URLscloses #1893
maybe helps with #1804