Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: docs: adds acc test setup #1910

Closed
wants to merge 4 commits into from
Closed

WIP: docs: adds acc test setup #1910

wants to merge 4 commits into from

Conversation

mavogel
Copy link
Member

@mavogel mavogel commented Nov 21, 2020

If applied, this commit will...

enhance the documentation for an acceptance test setup for gitlab and gitab

Why is this change being made?

Contributors can test releasing, brews and scoops locally and set-up quickly a local test environment.

Provide links to any relevant tickets, URLs or other resources

@vercel
Copy link

vercel bot commented Nov 21, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goreleaser/goreleaser/d8vg59mc4
✅ Preview: https://goreleaser-git-docs-acc-test-setup.goreleaser.now.sh

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 21, 2020
@codecov
Copy link

codecov bot commented Nov 21, 2020

Codecov Report

Merging #1910 (bd457db) into master (89105d6) will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1910      +/-   ##
==========================================
+ Coverage   81.73%   81.89%   +0.15%     
==========================================
  Files          73       74       +1     
  Lines        3866     3933      +67     
==========================================
+ Hits         3160     3221      +61     
- Misses        580      583       +3     
- Partials      126      129       +3     
Impacted Files Coverage Δ
internal/pipe/brew/brew.go 77.94% <0.00%> (-0.51%) ⬇️
cmd/root.go 100.00% <0.00%> (ø)
pkg/config/config.go 93.75% <0.00%> (ø)
internal/pipe/docker/docker.go 91.78% <0.00%> (ø)
internal/pipe/publish/publish.go 75.00% <0.00%> (ø)
internal/pipe/changelog/changelog.go 92.85% <0.00%> (ø)
internal/pipe/docker/manifest.go 96.22% <0.00%> (ø)
internal/pipe/nfpm/nfpm.go 94.41% <0.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89105d6...bd457db. Read the comment docs.

Copy link
Member

@caarlos0 caarlos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good so far, want to add more things to this PR?

@mavogel
Copy link
Member Author

mavogel commented Nov 24, 2020

yes, give me 1-2 days. bit busy atm

Co-authored-by: 6543 <6543@obermui.de>
@vercel vercel bot temporarily deployed to Preview November 28, 2020 08:15 Inactive
@caarlos0
Copy link
Member

will cherry pick these commits into master just so they go with the next release :)

@pull-request-size pull-request-size bot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 29, 2020
@vercel vercel bot temporarily deployed to Preview November 29, 2020 13:20 Inactive
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 29, 2020
@mavogel
Copy link
Member Author

mavogel commented Nov 29, 2020

When I run the script acc-tests/local-gitea.sh I get the error at the end for the command ssh -vvvT git@localhost -p 222

kex_exchange_identification: Connection closed by remote host

It is also not possible to git push

Current investigation

@6543 do you have any idea if this could a gitea issue? Or is more related to ssh

@caarlos0
Copy link
Member

It seems like this will be quite a lot of code... do you think its better if we put it in another repo?

@mavogel
Copy link
Member Author

mavogel commented Nov 30, 2020

Yes, TBH it would make sense to have a separate repo for this. Can you create one under the goreleaser org please?

@caarlos0
Copy link
Member

Yes, TBH it would make sense to have a separate repo for this. Can you create one under the goreleaser org please?

sure thing :)

https://github.com/goreleaser/acceptance-tests

not sure about the name, let me know if you have a better one :)

@mavogel
Copy link
Member Author

mavogel commented Dec 4, 2020

migrated to goreleaser/acceptance-tests#1

@mavogel mavogel closed this Dec 4, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2021
@caarlos0 caarlos0 deleted the docs-acc-test-setup branch May 31, 2021 16:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants