Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fine grained sign #2235

Merged
merged 2 commits into from May 21, 2021
Merged

feat: fine grained sign #2235

merged 2 commits into from May 21, 2021

Conversation

caarlos0
Copy link
Member

refs #1802

allow more options on artifacts.

@caarlos0
feat: fine grained sign
3b77bfe 
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@vercel
Copy link

vercel bot commented May 21, 2021 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goreleaser/goreleaser/HXpK5mPyzexuwHQUv4y1h5TwAQT1
✅ Preview: https://goreleaser-git-sign-goreleaser.vercel.app

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 21, 2021
@caarlos0 caarlos0 added enhancement New feature or request and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 21, 2021
@codecov
Copy link

codecov bot commented May 21, 2021 •
edited

Codecov Report

Merging #2235 (8c9f4f0) into master (00b7654) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2235      +/-   ##
==========================================
+ Coverage   82.70%   82.72%   +0.02%     
==========================================
  Files          76       76              
  Lines        4180     4186       +6     
==========================================
+ Hits         3457     3463       +6     
  Misses        587      587              
  Partials      136      136
Impacted Files Coverage Δ
internal/pipe/sign/sign.go 97.95% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00b7654...8c9f4f0. Read the comment docs.

@caarlos0 caarlos0 requested a review from radeksimko May 21, 2021 03:26
@caarlos0
fix: if
8c9f4f0 
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@vercel vercel bot temporarily deployed to Preview May 21, 2021 13:52 Inactive
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 21, 2021
@radeksimko radeksimko self-requested a review May 21, 2021 13:53
@caarlos0 caarlos0 merged commit 7cfa2c4 into master May 21, 2021
@caarlos0 caarlos0 deleted the sign branch May 21, 2021 14:16
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@caarlos0 @radeksimko