-
-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: auto-refresh checksums #2573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
pull-request-size
bot
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Oct 12, 2021
Codecov Report
@@ Coverage Diff @@
## main #2573 +/- ##
==========================================
+ Coverage 84.90% 84.95% +0.05%
==========================================
Files 105 105
Lines 7901 7951 +50
==========================================
+ Hits 6708 6755 +47
- Misses 978 980 +2
- Partials 215 216 +1
Continue to review full report at Codecov.
|
wagoodman
added a commit
to anchore/homebrew-syft
that referenced
this pull request
Oct 17, 2021
Workaround for goreleaser bug goreleaser/goreleaser#2573
wagoodman
added a commit
to anchore/homebrew-syft
that referenced
this pull request
Oct 17, 2021
Workaround for goreleaser bug goreleaser/goreleaser#2573 Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
luhring
pushed a commit
to anchore/homebrew-syft
that referenced
this pull request
Oct 17, 2021
Workaround for goreleaser bug goreleaser/goreleaser#2573 Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
This was referenced Oct 18, 2021
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows checksums to be "refreshed" at will.
The idea is, for instance, if your signing config replaces the original binary, you could have a config like this:
The pre-requisite is to sign the checksum as well to trigger the refresh. Maybe we can refresh it always in the end anyway?So, this now actually refreshes the checksums once the sign pipe finishes... which means that the checksums should always be up to date.
closes #1802