Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicate draft release in GitHub #3149

Closed
wants to merge 3 commits into from
Closed

fix: duplicate draft release in GitHub #3149

wants to merge 3 commits into from

Conversation

qsliu2017
Copy link
Contributor

For draft releases in GitHub, treat other draft releases with the same name as the same release.

Fix #3148

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 9, 2022
@qsliu2017 qsliu2017 changed the title fix: duplicate draft release fix: duplicate draft release in GitHub Jun 9, 2022
@caarlos0
Copy link
Member

caarlos0 commented Jun 9, 2022

this is not going to work, unless we also remove all existing release artifacts first

@qsliu2017
Copy link
Contributor Author

updated. @caarlos0 please take a look

@caarlos0
Copy link
Member

I wonder if it isn't easier to just delete the draft release if it already exits before creating a new one?

thoughts?

@caarlos0
Copy link
Member

fixed in #3318

@caarlos0 caarlos0 closed this Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not create duplicate draft release in GitHub
2 participants