Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(changelog): group regexps #3527

Merged
merged 5 commits into from Nov 7, 2022
Merged

fix(changelog): group regexps #3527

merged 5 commits into from Nov 7, 2022

Commits on Nov 7, 2022

  1. fix(changelog): group regexps 

    Fix the regular expressions used in changelog group processing to valid
golang (RE2) regexps. These previously used PCRE character class \w which
is not supported in RE2 which is what golang regexp uses.

Document that format matches not just title as some may thing but
the format "<abbrev-commit> <title-commit>".

This also include "!" as defined by conventional commits.
    @stevenh
    stevenh committed Nov 7, 2022
    Copy the full SHA
    61d47a4 View commit details
    Browse the repository at this point in the history

  2. chore(changelog): note regexp is re2 syntax 

    Note changelog group regexp parameters are in RE2 syntax.
    @stevenh
    stevenh committed Nov 7, 2022
    Copy the full SHA
    d9cdc6a View commit details
    Browse the repository at this point in the history

  3. fix: use xdigit for abbrev-commit match 

    Use [[:xdigit:]] to match the abbrev-commit, which is clearer as to the
intent and correct as the previous version had a typo anyway.
    @stevenh
    stevenh committed Nov 7, 2022
    Copy the full SHA
    ba5bcda View commit details
    Browse the repository at this point in the history

  4. fix(changelog): github pattern matching 

    GitHub has different output than the tests, including a colon after the
commit reference, so make the pattern resilient to that and other
nuisances by making it a full wild card but non greedy.

Also:
* Remove processed entries instead of striking them out, allowing early
  exit when we're done.
* Add group match debugging to users can see what's going on with --debug.
    @stevenh
    stevenh committed Nov 7, 2022
    Copy the full SHA
    6c52a8a View commit details
    Browse the repository at this point in the history

  5. fix(changelog): invalid index access 

    Fix invalid invalid index access in changelog processing when removing
processed items.
    @stevenh
    stevenh committed Nov 7, 2022
    Copy the full SHA
    ffe9559 View commit details
    Browse the repository at this point in the history