build: test on windows too #3795
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
pull-request-size
bot
added
the
size/XS
caarlos0
added
enhancement
Deploying with
|
| Latest commit: |
9528f0c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://19cb888e.goreleaser.pages.dev |
| Branch Preview URL: | https://windows.goreleaser.pages.dev |
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
pull-request-size
bot
added
the
size/XS
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #3795 +/- ##
==========================================
- Coverage 83.64% 83.54% -0.10%
==========================================
Files 130 124 -6
Lines 12216 10960 -1256
==========================================
- Hits 10218 9157 -1061
+ Misses 1597 1445 -152
+ Partials 401 358 -43
|
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
pull-request-size
bot
added
size/S
pull-request-size
bot
added
size/L
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
This was referenced Jun 16, 2023
Merged
caarlos0
added a commit
that referenced
this pull request
Jun 16, 2023
improved test check extracted from #3795
caarlos0
added a commit
that referenced
this pull request
Jun 16, 2023
this is needed when we run part of the pipeline on windows, and the rest on linux, for example, the split build pro feature. extracted from #3795 + added tests for relative path thing Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
caarlos0
added a commit
that referenced
this pull request
Jun 16, 2023
extracted from #3795 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
caarlos0
added a commit
that referenced
this pull request
Jun 16, 2023
extracted from #3795 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
|
being continued in #4293 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this ought to be painful, but its time, probably...