-
-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ko): support labels and creation times #3852
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good overall.
I guess we should also check that the actual end image has the labels?
On Docker tests, line 54, we have a shouldFindImagesWithLabels
which I think we can copy/edit as needed here...
Other than that, great work! Thanks for the PR 🙏
This comment was marked as resolved.
This comment was marked as resolved.
lgtm, great catch, thanks for making this! |
be2f9e2
to
1691d7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what I have done does not work
nvm, I confused labels which are in the config with manifest annotations
I added more tests for the labels, but also for the platforms and SBOM, and caught a bug!
I tried to use Bare: true
for the tests to make the image reference easier to build, but I get an error:
publish: GET http://localhost:5052/v2/goreleasertest/testapp/blobs/uploads/: BLOB_UPLOAD_UNKNOWN: blob upload unknown to registry
No idea why it makes a GET
request and not a POST
😕
thanks! This looks good, will go out on v1.17 (by EOM). |
Codecov Report
@@ Coverage Diff @@
## main #3852 +/- ##
==========================================
+ Coverage 83.34% 83.40% +0.06%
==========================================
Files 123 123
Lines 10581 10620 +39
==========================================
+ Hits 8819 8858 +39
Misses 1431 1431
Partials 331 331
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
1691d7a
to
76419b0
Compare
a476aaa
to
12ef6dc
Compare
@caarlos0 I added creation times too, let me know if it is ok with you 🙂 |
12ef6dc
to
6e2bf19
Compare
Thank you! |
labels
key-value map to thekos
config.My interest is to be able to label the built images: https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#labelling-container-images