New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue 3759] Support direct buildkit builds without requiring a docker daemon on the build host #4504
base: main
Are you sure you want to change the base?
Conversation
03b8434
to
ce4064b
Compare
Hey, thanks for the PR! 🤘
Yes! It's something I've been meaning to work in for a while now as well.
Yes. I would probably call it I see some code is copied from the docker pipe, maybe we should put it in a lib in the internal package for reuse? |
I updated the PR to use containers and allow the definition of more builders along the way.
A missing step today is how to distinguish a If this looks okay I'll work on the unit tests |
I don't think we have that now... but seems like something good to have. Will PR it ASAP. |
refs #4504 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
…r daemon on the build host
…gh without multi-platform), docker with containerd image store and kubernetes builders
e5da624
to
14dd7ba
Compare
@caarlos0 Thanks for the commit. I updated the PR with:
If this looks okay to you I'll start working on the tests once you confirm this would be going this direction. I'll also likely split the PR in multiple stacked one if you're okay with me using graphite |
14dd7ba
to
c009954
Compare
hey, sorry for the delay, this does look good to me so far, yes! thanks for all the work and effort here btw 🙏 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4504 +/- ##
==========================================
- Coverage 83.83% 81.32% -2.52%
==========================================
Files 135 142 +7
Lines 12850 13314 +464
==========================================
+ Hits 10773 10827 +54
- Misses 1652 2056 +404
- Partials 425 431 +6 ☔ View full report in Codecov by Sentry. |
Hey @valerian-roche, is there anything i can do to help u completing this PR? |
Hey, sorry for the delay. I have had conflicting priorities and haven't had anytime to work on unit testing this sadly.
If you have some bandwidth to work on testing that'd be great, otherwise I plan on coming back to the PR later on when I'll have more capacity |
This PR is currently a draft and does not aim at being merged as is, but I'd like feedback on:
buildx build
covers all three). I initially wanted to merge the configuration part but it ended up far too confusingIf this is the correct direction, I'll go on with:
goreleaser build
(it's currently simply skipped). Build can still be tested throughrelease --snapshot
. I'll potentially end up withrelease --snapshot
not using--load
andbuild
using--load
and failing if a daemon is not presentFor now I was able to test:
release --snapshot
, including when setting multiple architecturesrelease
, including with multiple platforms