Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove disgo dependency #4521

Merged
merged 2 commits into from Jan 5, 2024
Merged

fix: remove disgo dependency #4521

merged 2 commits into from Jan 5, 2024

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Jan 5, 2024

closes #4520

it was easy enough to remove it :)

@caarlos0 caarlos0 added the bug Something isn't working label Jan 5, 2024
@caarlos0 caarlos0 added this to the v1.24.0 milestone Jan 5, 2024
@caarlos0 caarlos0 self-assigned this Jan 5, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 5, 2024
Copy link

cloudflare-pages bot commented Jan 5, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e2be876
Status: ✅  Deploy successful!
Preview URL: https://aec46fba.goreleaser.pages.dev
Branch Preview URL: https://discord.goreleaser.pages.dev

View logs

@caarlos0 caarlos0 mentioned this pull request Jan 5, 2024
4 tasks
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (0becc41) 83.83% compared to head (e2be876) 83.77%.

Files Patch % Lines
internal/pipe/discord/discord.go 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4521      +/-   ##
==========================================
- Coverage   83.83%   83.77%   -0.07%     
==========================================
  Files         135      135              
  Lines       12850    12860      +10     
==========================================
  Hits        10773    10773              
- Misses       1652     1662      +10     
  Partials      425      425              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caarlos0 caarlos0 merged commit 2ab840b into main Jan 5, 2024
10 of 12 checks passed
@caarlos0 caarlos0 deleted the discord branch January 5, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unlicensed indirect dependency
1 participant