Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply template to gobinary #4675

Closed
wants to merge 1 commit into from

Conversation

nekohasekai
Copy link
Contributor

Useful for people who want to customize go but don't want to use golang.org/dl wrappers

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 8, 2024
@caarlos0
Copy link
Member

Useful for people who want to customize go but don't want to use golang.org/dl wrappers

The PR look ok, but I don't understand what golang.org/dl has to do with this... could you explain?

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 85.44%. Comparing base (c68d830) to head (d206389).
Report is 75 commits behind head on main.

Files Patch % Lines
internal/builders/golang/build.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4675      +/-   ##
==========================================
+ Coverage   83.77%   85.44%   +1.67%     
==========================================
  Files         135      136       +1     
  Lines       13029    10787    -2242     
==========================================
- Hits        10915     9217    -1698     
+ Misses       1677     1132     -545     
- Partials      437      438       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nekohasekai
Copy link
Contributor Author

I see I'm a duplicate of #4454 but his code doesn't work, I'll open a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants