Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix nolintlint issues #4854

Merged
merged 2 commits into from
May 12, 2024
Merged

Conversation

alexandear
Copy link
Contributor

The PR enables nolintlint linter and fixes up appeared issues.

Changes:

  • Enable nolintlint in .golangci.yml config.
  • Remove unused //nolint: comments.
  • Fix nolint comment format by removing spaces (// nolint: dupl -> //nolint:dupl)

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 11, 2024
Copy link

codecov bot commented May 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.81%. Comparing base (c68d830) to head (328f5fe).
Report is 261 commits behind head on main.

❗ Current head 328f5fe differs from pull request most recent head 93783a7. Consider uploading reports for the commit 93783a7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4854      +/-   ##
==========================================
+ Coverage   83.77%   83.81%   +0.03%     
==========================================
  Files         135      139       +4     
  Lines       13029    11232    -1797     
==========================================
- Hits        10915     9414    -1501     
+ Misses       1677     1355     -322     
- Partials      437      463      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@caarlos0 caarlos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@caarlos0 caarlos0 merged commit 6505654 into goreleaser:main May 12, 2024
8 of 9 checks passed
@alexandear alexandear deleted the chore/fix-nolintlint branch May 12, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants