fix: replace getRefNativeTag with findNodeHandle #1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tested v5 with/without new arch, it is not throwing this error |
|
Really!? so it's unnecessary in v5, feel free to close the PR if so. @gorhom |
|
@gorhom can confirm v5 is not entirely working on new arch. I'm getting this after switching to new arch (also tried updating from alpha 9 to 10) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide enough information so that others can review your pull request:
Motivation
Trying to fix this issue when new arch is enabled: #1726
Current
getRefNativeTagcauses this issue with new architecture:By reverting to findNodeHandle it works:
fabric-enabled-ios.mp4
We had introduced
getRefNativeTagbecause experimental new architecture last year did not support using findNodeHandle. This is no longer true with the proxy renderer they created.This was tested with and without new architecture enabled on iOS.