Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guess the scheme if r.URL.Scheme is unset #474

Merged
merged 5 commits into from Oct 18, 2019

Commits on Jul 3, 2019

  1. Guess the scheme if r.URL.Scheme is unset

    It's not expected that the request's URL is fully populated when used on
    the server-side (it's more of a client-side field), so we shouldn't
    expect it to be present.
    
    In practice, it's only rarely set at all on the server, making mux's
    `Schemes` matcher tricky to use as it is.
    
    This commit adds a test which would have failed before demonstrating the
    problem, as well as a fix which I think makes `.Schemes` match what
    users expect.
    euank committed Jul 3, 2019
    Copy the full SHA
    dc6bf41 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    3d555f2 View commit details
    Browse the repository at this point in the history
  3. Add route url test for schemes

    euank committed Jul 3, 2019
    Copy the full SHA
    a038e0d View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    7b0a1dc View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2019

  1. Copy the full SHA
    6a87310 View commit details
    Browse the repository at this point in the history