Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go version, add tools for verification and testing #263

Merged
merged 1 commit into from Jul 23, 2023

Conversation

coreydaley
Copy link
Contributor

Fixes #

Summary of Changes

PS: Make sure your PR includes/updates tests! If you need help with this part, just ask!

@catatsuy
Copy link

@coreydaley I saw you're planning to get rid of CircleCI settings. But, I've got a different idea that could be great for this project.

I've sent a Pull Request (#262 gorilla/securecookie#79) where I've switched CircleCI over to GitHub Actions. With this, we can still do all our old tests and even use the newest version of Go. It's like keeping the good stuff we had and making sure it works with any new Go versions too.

If we just delete CircleCI and don't replace it with something like GitHub Actions, we might mess up our tests or have issues with the newest Go. But with GitHub Actions, we keep our testing strong and up-to-date, which is really good for our work here.

I think my PR is a good move for the project. I hope you can take another look at it. Let me know if you've got any questions, okay?

@coreydaley
Copy link
Contributor Author

@catatsuy Thank you for the pull request, we are currently working on swapping out circleci for github actions as part of the project transition, starting with gorilla/mux#718

@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@956d3cf). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #263   +/-   ##
=======================================
  Coverage        ?   76.86%           
=======================================
  Files           ?        4           
  Lines           ?      268           
  Branches        ?        0           
=======================================
  Hits            ?      206           
  Misses          ?       54           
  Partials        ?        8           

@coreydaley coreydaley force-pushed the coreydaley-patch-1 branch 20 times, most recently from 148980f to 5493726 Compare July 23, 2023 02:16
@coreydaley coreydaley changed the title Delete .circleci directory Update go version, add tools for verification and testing Jul 23, 2023
@coreydaley coreydaley force-pushed the coreydaley-patch-1 branch 2 times, most recently from 4ea2103 to 8ec7ceb Compare July 23, 2023 02:21
AlexVulaj
AlexVulaj previously approved these changes Jul 23, 2023
@coreydaley coreydaley merged commit b1daf6d into main Jul 23, 2023
11 checks passed
@coreydaley coreydaley deleted the coreydaley-patch-1 branch July 23, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants