Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds portuguese language & @ symbols #79

Merged
merged 2 commits into from Feb 23, 2024

Conversation

auyer
Copy link
Contributor

@auyer auyer commented Feb 7, 2023

This PR adds the Portuguese language

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f701be4) to head (d353393).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #79   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          119       121    +2     
=========================================
+ Hits           119       121    +2     
Files Coverage Δ
languages_substitution.go 100.00% <ø> (ø)
slug.go 100.00% <100.00%> (ø)

Copy link

@IamNator IamNator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed PR and confirmed that the following substitutions for Portuguese are correct: '&' -> 'e', '@' -> 'em'. Also verified the following language abbreviations: 'pt', 'prt', 'pt-br', 'por'. No further issues found.

@IamNator
Copy link

IamNator commented Apr 9, 2023

Reviewed PR and confirmed that the following substitutions for Portuguese are correct: '&' -> 'e', '@' -> 'em'. Also verified the following language abbreviations: 'pt', 'prt', 'pt-br', 'por'. No further issues found.

"pt" is the ISO 639-1 language code for Portuguese.
"prt" is another abbreviation used for Portuguese, which is derived from the three-letter ISO 639-2 code for the language.
"pt-br" is the language code used for Brazilian Portuguese, which is a variation of the Portuguese language spoken in Brazil.
"bra" is not a commonly used abbreviation for Portuguese. However, it could be an abbreviation for Brazil, which is a country where Portuguese is the official language.
"por" is a three-letter ISO 639-2 code for Portuguese, which is used to represent the language in various contexts.

@IamNator
Copy link

IamNator commented Apr 9, 2023

Reviewed PR and confirmed that the following substitutions for Portuguese are correct: '&' -> 'e', '@' -> 'em'. Also verified the following language abbreviations: 'pt', 'prt', 'pt-br', 'por'. No further issues found.

'&' is commonly substituted by "e" in Portuguese, which means "and" in English.

'@' is usually substituted by "em" in Portuguese, which means "in" or "on" in English.

@matrixik matrixik changed the title Adds portuguese language Adds portuguese language & @ symbols Feb 23, 2024
@matrixik matrixik merged commit 4a8e359 into gosimple:master Feb 23, 2024
6 checks passed
@matrixik
Copy link
Member

Thank you for this and sorry it took so long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants