Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump alpine linux to 3.19 #907

Merged
merged 2 commits into from
May 31, 2024
Merged

bump alpine linux to 3.19 #907

merged 2 commits into from
May 31, 2024

Conversation

dklimpel
Copy link
Contributor

@dklimpel dklimpel commented May 10, 2024

Checklist
  • make test-all (UNIX) passes. CI will also test this
  • unit and/or integration tests are included (if applicable)
  • documentation is changed or added (if applicable)

Description of change

Bump Alpine Linux in integration test.

@dklimpel dklimpel marked this pull request as ready for review May 10, 2024 18:34
@dklimpel dklimpel requested a review from aelsabbahy as a code owner May 10, 2024 18:34
@aelsabbahy
Copy link
Member

aelsabbahy commented May 26, 2024

There's some logic to publish the docker images with a checksum to speed up future CI builds. Basically, CI will download the built image instead of rebuilding it.

I wonder if those would perform faster in ghcr when this is all running as GitHub actions. 🤔

@dklimpel
Copy link
Contributor Author

I saw the logic with the checksums. It can stay and will certainly speed things up in the future and prevent unnecessary docker builds. I can update the checksum, but not the container image on docker hub.

I see two options. Either live with a slow pipeline and update the containers and checksums at the end of all image updates.

Or first implement the new pipeline to build the containers via ghcr (or docker hub).

@aelsabbahy
Copy link
Member

Agree with your assessment,

  1. I'll manually update the image + checksum for now. The logic just falls back to slower builds, so nothing is broken.
  2. When pipelines are ready, they will be responsible for updating the images after successful CI. This way whenever we make image changes, they're slow at first, but speed up once CI passes in master branch.

@aelsabbahy aelsabbahy merged commit 855c3ce into goss-org:master May 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants