Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle corner case of multiple inheritance in UnnecessaryAbstractClass rule #1

Merged
merged 65 commits into from
Jul 10, 2022
Merged

Commits on Jun 11, 2022

  1. Drop dependency-analysis plugin (detekt#4946)

    This is blocking update to Kotlin 1.7.0 (detekt#4821)
    3flex committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    e33878c View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2022

  1. Gradle Enterprise Trial (detekt#4763)

    * Refactor `JvmSpec` to avoid using test resources
    
    * Build a utility to copy resource files into temporary files
    
    * Fix deprecation warning on jacocoMergedReport
    
    * Add back `jvm` test fixtures
    
    * Enabled Remote Build cache
    
    * Change androidSdkInstalled to a boolean flag
    
    * Use consistent warningsAsErrors
    
    * Enable local build cache
    
    * Fix MaxLineLength violation
    
    * Update build-logic/src/main/kotlin/module.gradle.kts
    
    Co-authored-by: Brais Gabín <braisgabin@gmail.com>
    
    * Add a separate job to enable `warningsAsErrors`
    
    Co-authored-by: Nicola Corti <corti.nico@gmail.com>
    Co-authored-by: Brais Gabín <braisgabin@gmail.com>
    3 people committed Jun 12, 2022
    Configuration menu
    Copy the full SHA
    d06b109 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2022

  1. Pin Github Actions SHAs (detekt#4938)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>
    renovate[bot] and renovate-bot committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    44d0e81 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d3cdbb6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    43e0a4a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1d47fd3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    43ea42c View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2022

  1. Add Markdown report (detekt#4858)

    Co-authored-by: Brais Gabín <braisgabin@gmail.com>
    VitalyVPinchuk and BraisGabin committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    5d49409 View commit details
    Browse the repository at this point in the history
  2. Improve readme (detekt#4914)

    * Move integrations down
    
    * Remove old integration
    
    * Move more integrations down
    
    * More improvements
    
    * Improve the detekt features
    
    * Update link
    
    * Improve website/docs/intro.mdx
    
    * Add links to kotlin homepage
    
    * Update README.md
    
    Co-authored-by: schalkms <30376729+schalkms@users.noreply.github.com>
    
    * Add complexity reports back
    
    Co-authored-by: schalkms <30376729+schalkms@users.noreply.github.com>
    BraisGabin and schalkms committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    a10e957 View commit details
    Browse the repository at this point in the history
  3. Update plugin binaryCompatibilityValidator to v0.10.1 (detekt#4954)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>
    renovate[bot] and renovate-bot committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    feec74c View commit details
    Browse the repository at this point in the history
  4. Update react monorepo to v18.2.0 (detekt#4958)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>
    renovate[bot] and renovate-bot committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    195d15a View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2022

  1. Set strict dependency on tested Kotlin compiler version (detekt#4822)

    This effectively pins the Kotlin compiler version used by detekt-cli,
    minimising the chance of it being overridden and causing issues such as
    detekt#4786
    3flex committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    e8e1f35 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2022

  1. Update dependency com.github.breadmoirai:github-release to v2.4.1 (de…

    …tekt#4965)
    
    Co-authored-by: Renovate Bot <bot@renovateapp.com>
    renovate[bot] and renovate-bot committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    8b62ffc View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2022

  1. Configuration menu
    Copy the full SHA
    b06276a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    06ee239 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2022

  1. Configuration menu
    Copy the full SHA
    ecd28cf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bd262c6 View commit details
    Browse the repository at this point in the history
  3. Update gradle/gradle-build-action digest to 67421db (detekt#4977)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    bdec78d View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2022

  1. Update dependency org.jetbrains.kotlinx:kotlinx-coroutines-core to v1…

    ….6.3 (detekt#4976)
    
    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    75f38dc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7832eef View commit details
    Browse the repository at this point in the history
  3. Add instuctions for CLI installation using Scoop (detekt#4984)

    Alex Stelmachonak committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    0e67d14 View commit details
    Browse the repository at this point in the history
  4. Add CascadingCallWrapping style rule (detekt#4979)

    Add a new rule CascadingCallWrapping which requires that if a chained call is placed on a newline then all subsequent calls must be as well, improving readability of long chains.
    dzirbel committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    89f6ec1 View commit details
    Browse the repository at this point in the history
  5. Do not allow junit assertions (detekt#4987)

    Co-authored-by: Markus Schwarz <post@markus-schwarz.net>
    marschwar and Markus Schwarz committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    4979e37 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8dc783a View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2022

  1. Fix false-negative for CanBeNonNullable (detekt#4993)

    * Report null-check returning 'Unit'
    
    The rule will report code smell when null-check expression returns 'Unit'
    
    * Not report guard statement with side effect ahead
    VitalyVPinchuk committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    4742842 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2022

  1. Update actions/setup-java digest to 16cca54 (detekt#4996)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    3d0f215 View commit details
    Browse the repository at this point in the history
  2. Update github/codeql-action digest to 41a4ada (detekt#4981)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    4441bc4 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2022

  1. Support markdown report in Gradle plugin (detekt#4995)

    * Support markdown report in Gradle plugin
    
    * Add markdown description to website docs
    
    * Improve markdown description for website docs
    VitalyVPinchuk committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    3b7cae1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5170077 View commit details
    Browse the repository at this point in the history
  3. Fix Signatures.kt:buildFunctionSignature (detekt#4961)

    * Fix Signatures.kt:buildFunctionSignature
    
    'buildFunctionSignature' fails when function body has KDoc.
    
    * Simplify tests
    
    * Skip comments
    VitalyVPinchuk committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    2b068e0 View commit details
    Browse the repository at this point in the history
  4. Update dependency org.jetbrains.dokka to v1.7.0 (detekt#4974)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    0c879a7 View commit details
    Browse the repository at this point in the history
  5. UnnecessaryApply: fix false negative for assignment (detekt#4948)

    Fix a missed case of UnnecessaryApply where the apply contains a single field assignment but the result of the apply{} is unused. This pattern is actually used in 2/3 of the <noncompliant> examples and while it occurred in tests for false positives, no test actually checked that warnings were generated in the simple case.
    dzirbel committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    c8eb24c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5ff82e1 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2022

  1. Configuration menu
    Copy the full SHA
    5d6ee2f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    29158af View commit details
    Browse the repository at this point in the history
  3. Add MaxChainedCallsOnSameLine style rule (detekt#4985)

    Add a new rule MaxChainedCallsOnSameLine to limit the number of chained calls on placed on a single line. This works well alongside CascadingCallWrapping in detekt#4979 to make long call chains more readable by wrapping them on new lines.
    dzirbel committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    1e696fd View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2022

  1. Configuration menu
    Copy the full SHA
    5c39d7d View commit details
    Browse the repository at this point in the history
  2. Update github/codeql-action digest to 3f62b75 (detekt#5007)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    0a00c2a View commit details
    Browse the repository at this point in the history
  3. Update plugin pluginPublishing to v1.0.0 (detekt#5010)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    bea15be View commit details
    Browse the repository at this point in the history
  4. Allow constants to be skipped for BooleanPropertyNaming rule (detekt#…

    …5006)
    
    Co-authored-by: Amit Dash <amitdash@Amit-Dash.local>
    amitdash291 and Amit Dash committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    49c6d88 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2022

  1. Configuration menu
    Copy the full SHA
    58d4b8e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    292372e View commit details
    Browse the repository at this point in the history
  3. Removes documentation formatting issue (detekt#5017)

    * Removes documentation formatting issue
    
    * Removes extra caracter
    jlengrand committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    246ccd8 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2022

  1. Add test for ForbiddenMethodCall with getters (detekt#5018)

    See: ForbiddenMethodCall with Kotlin getters as property detekt#5015
    schalkms committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    cf8bd5e View commit details
    Browse the repository at this point in the history
  2. Update dependency prism-react-renderer to v1.3.5 (detekt#5019)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    b037183 View commit details
    Browse the repository at this point in the history
  3. Update JamesIves/github-pages-deploy-action digest to e6d003d (detekt…

    …#5023)
    
    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    fbb913b View commit details
    Browse the repository at this point in the history
  4. Add endColumn/endLine to SARIF region (detekt#5011)

    * Add endColumn/endLine to SARIF region
    
    * Add fixes
    
    Replace toSet() with distinct(), get rid of null check.
    
    * Get rid of 'mockk'
    
    * Fix line order
    VitalyVPinchuk committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    b49aea7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1322deb View commit details
    Browse the repository at this point in the history
  6. Fix ReturnCount debt and refactor code (detekt#5026)

    * Fix ReturnCount debt in UnnecessaryBackticks
    
    * Remove code duplication in NullableBooleanCheck
    
    * Fix MultilineIfElse debt
    amitdash291 committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    ddcf77d View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2022

  1. detekt#5014 Fix MaxChainedCallsOnSameLine false positives (detekt#5020)

    Fix issues where MaxChainedCallsOnSameLine would report long import and package directives, where a warning certainly isn't necessary.
    dzirbel committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    6edf6bb View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2022

  1. Update dependency clsx to v1.2.0 (detekt#5031)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    c953140 View commit details
    Browse the repository at this point in the history
  2. MaxChainedCallsOnSameLine: don't count package references as chained …

    …calls (detekt#5036)
    
    * MaxChainedCallsOnSameLine: don't count package references as chained calls
    
    * Use compileAndLintWithContext
    t-kameyama committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    aa2a1bf View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2022

  1. Update dependency clsx to v1.2.1 (detekt#5039)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    08a196a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2add9e7 View commit details
    Browse the repository at this point in the history
  3. Fix ComplexMethod debt and refactor code (detekt#5029)

    * Fix ComplexCondition debt and refactor code
    
    * Remove unnecessary parentheses
    amitdash291 committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    1a6d059 View commit details
    Browse the repository at this point in the history
  4. Only recommend using index accessors for Java classes that are known …

    …collections (detekt#4994)
    
    * Refactor: clear separation between "can" and "recommended" replace
    
    This also provides a less strict and universal implementation for the previous type parameters bugfix: detekt#4803
    
    As commented in the code, it does this by doing a lazy attempt at whether type inference is possible. If needed, this can be extended on later.
    
    * Fix: non-sensical index accessor recommendations for java classes
    
    Closes detekt#4918
    
    * Refactor: use default Java sources for ExplicitCollectionElementAccess test
    Whathecode committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    46aa36f View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2022

  1. Xml Report Merger now merges duplicate smells across input report fil…

    …es (detekt#5033)
    
    * Xml Report Merger now merges duplicate smells across input report files
    
    * Mock time in MarkdownReportSpec for more consistent test results
    
    * Update detekt-gradle-plugin/src/main/kotlin/io/gitlab/arturbosch/detekt/report/XmlReportMerger.kt
    
    Co-authored-by: Tim Oltjenbruns <tim.oltjenbruns@softvision.com>
    Co-authored-by: Chao Zhang <zhangchao6865@gmail.com>
    3 people committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    b6448e3 View commit details
    Browse the repository at this point in the history
  2. Add ending line and column to Location.kt (detekt#5032)

    * Add ending line and column to Location.kt
    
    * Revert changes to detekt-api.api
    
    * Add tests for Location.kt
    
    * Add new line to comply with format
    
    Co-authored-by: schalkms <30376729+schalkms@users.noreply.github.com>
    VitalyVPinchuk and schalkms committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    6638b2f View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2022

  1. Enable strict Kotlin DSL precompiled script plugins accessors generat…

    …ion (detekt#5048)
    
    This opts-in to a stricter mode of operation that fails the build when a
    plugin application fails, and enables the build cache for the
    :generatePrecompiledScriptPluginAccessors task.
    
    This will be the default in Gradle 8.0, but there's no reason not to enable
    this in advance of that release given our build is stable with it enabled.
    3flex committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    8940fb6 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2022

  1. Drop redundant workaround (detekt#5057)

    This workaround is no longer required as of Kotlin 1.6.20.
    3flex committed Jul 9, 2022
    Configuration menu
    Copy the full SHA
    7cdd6ca View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8903b2e View commit details
    Browse the repository at this point in the history
  3. Update ktlint links from website to readme (detekt#5056)

    Links either point to the standard or experimental section in the readme.
    
    Closes detekt#5054
    schalkms committed Jul 9, 2022
    Configuration menu
    Copy the full SHA
    2e6f16b View commit details
    Browse the repository at this point in the history
  4. Update docusaurus monorepo to v2.0.0-beta.22 (detekt#5050)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] committed Jul 9, 2022
    Configuration menu
    Copy the full SHA
    b643772 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    675c48c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    69b3fd3 View commit details
    Browse the repository at this point in the history