Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add board config input form components #259

Merged
merged 3 commits into from May 15, 2024
Merged

Conversation

merowin
Copy link
Collaborator

@merowin merowin commented May 13, 2024

This adds components for input forms for the various board configs. I tried to streamline these components by having one dedicated component for each board pattern.
With this it will be possible to create and play games with the new board patterns for variants baduk, phantom, capture, tetris, thue-morse, and one-color.
For variants freeze and quantum it should not be too much work to also enable this, but since these have their own board component, I'd like to do this in a separate PR.

It's worth noting that there's a couple of possible improvements that I've ignored for now.
1.) The graph board component doesn't use the annotations yet.
2.) At the moment, the newly added config input forms don't use the default config as defined by the variant itself, but their own default config.

@benjaminpjones
Copy link
Collaborator

I tried to streamline these components by having one dedicated component for each board pattern.

Solid design choice.

With this it will be possible to create and play games with the new board patterns for variants baduk, phantom, capture, tetris, thue-morse, and one-color.

Nice to see it all come together!

@merowin merowin merged commit c8f1afd into main May 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants