Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dynatrace to the ECS container #1183

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add Dynatrace to the ECS container #1183

wants to merge 8 commits into from

Conversation

melvabout
Copy link

What?

Add the dynatrace container to the frontend.

Why?

So that application metrics will be ingested into dynatrace.

Performance Analysis have been informed of the change

  • Performance Analysis have been informed of the change
  • [ ]

@melvabout melvabout added the enhancement New feature or request label Oct 20, 2023
@melvabout melvabout changed the title F/obs 31 Add Dynatrace to the ECS container Oct 20, 2023
@dbes-gds
Copy link
Contributor

Could we do a switch to rollout per environment?

@melvabout
Copy link
Author

@dbes-gds, @two-first-names You could add conditionals into the docker file, but that wouldn't give you deployment control per environment. I can't see a terraform apply in the workflows and it looks like a zip of terraform is created, so I assume that secure pipeline calls the terraform apply command? I think the only way to control this then would be to have two Docker images one with dynatrace and one with out and then you could use the variables image_uri, image_tag and image_digest in each environment to control the deployment. I don't have access to the aws accounts so this is an assumption. Thoughts?

@sonarcloud
Copy link

sonarcloud bot commented Oct 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants