Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AUT-2393: Axios upgrade from 0.25.0 to 0.1.6.8 #1555

Merged
merged 1 commit into from Apr 26, 2024
Merged

AUT-2393: Axios upgrade from 0.25.0 to 0.1.6.8 #1555

merged 1 commit into from Apr 26, 2024

Conversation

ayoshebby
Copy link
Contributor

@ayoshebby ayoshebby commented Apr 15, 2024 •
edited

What

Bumps axios from 0.25.0 to 1.6.8.

Release notes:

Bug Fixes

@ayoshebby ayoshebby requested review from a team as code owners April 15, 2024 15:37
@ayoshebby ayoshebby changed the title AUT-2393: Axios upgrade WIP AUT-2393: Axios upgrade Apr 18, 2024
@ayoshebby ayoshebby force-pushed the AUT-2393 branch 2 times, most recently from 6cd8480 to bf459a7 Compare April 18, 2024 08:59
BeckaL
BeckaL reviewed Apr 19, 2024
View reviewed changes
Copy link
Contributor

@BeckaL BeckaL left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we reword the commit to remove the WIP comment? Also, do we need a particular rollout plan? Have we tested this in some environment?

src/assets/javascript/cookies.js Outdated Show resolved Hide resolved
src/utils/http.ts Outdated Show resolved Hide resolved
mattvot
mattvot reviewed Apr 23, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@ayoshebby ayoshebby force-pushed the AUT-2393 branch 6 times, most recently from 7de290f to 6ce7bed Compare April 24, 2024 12:53
@ayoshebby ayoshebby changed the title AUT-2393: Axios upgrade AUT-2393: Axios upgrade 1.6.8 Apr 24, 2024
@ayoshebby ayoshebby changed the title AUT-2393: Axios upgrade 1.6.8 AUT-2393: Axios upgrade from 0.25.0 to 0.1.6.8 Apr 24, 2024
mattvot
mattvot reviewed Apr 25, 2024
View reviewed changes
Copy link
Contributor

@mattvot mattvot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just trying to assess if any more changes are required / we're not going to have hidden issues around. I've one suggestion for the moment.

src/utils/http.ts Outdated Show resolved Hide resolved
mattvot
mattvot previously approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@mattvot mattvot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just ran through some smoke testing and seen the flows work when targeting the build env. Approved.

@ayoshebby ayoshebby force-pushed the AUT-2393 branch 2 times, most recently from 2a65cdd to 7733f14 Compare April 26, 2024 09:05
@ayoshebby
AUT-2393: Axios upgrade from 0.25.0 to 0.28.0
87537a2 
- Resolve ts error enforcing to implement other missing properties of AxiosHeaders
@ayoshebby ayoshebby merged commit f003083 into main Apr 26, 2024
3 checks passed
@ayoshebby ayoshebby deleted the AUT-2393 branch April 26, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattvot mattvot mattvot approved these changes

@BeckaL BeckaL BeckaL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ayoshebby @mattvot @BeckaL