Aut 2578/use common headers in all services #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeckaL
force-pushed
the
AUT-2578/use-common-headers-in-all-services
branch
6 times, most recently
from
6214cc8
to
64354ea
Compare
andrew-moores
previously approved these changes
May 21, 2024
This means that we submit txma security headers in requests to the backend.
This means that we submit txma security headers in requests to the backend.
This means that we submit txma security headers in requests to the backend.
This means that we submit txma security headers in requests to the backend.
This means that we submit txma security headers in requests to the backend.
This means that we submit txma security headers in requests to the backend.
…aders This means that we submit txma security headers in requests to the backend.
This means that we submit txma security headers in requests to the backend.
This means that we submit txma security headers in requests to the backend.
This means that we submit txma security headers in requests to the backend.
This means that we submit txma security headers in requests to the backend.
This means that we submit txma security headers in requests to the backend.
This means that we submit txma security headers in requests to the backend.
This means that we submit txma security headers in requests to the backend. Note that the interface of the reset password service specifies an isForcedPassword param, which wasn't specified on the implementation. Making this change required us to add this parameter too otherwise our tests would not compile. However, the isForcedPasswordReset parameter is unused which is a small bug in our service which we'll fix subsequently
This means that we submit txma security headers in requests to the backend.
Make casing consistent with other files
This means that we submit txma security headers in requests to the backend.
All internal requests are now converted to the new getInternalRequestConfigWithSecurityHeaders function, which sets security headers. Therefore, this function is now redundant and can be removed.
This is no longer required, as all services now expect the version of headers with the security keys
The x-forwarded-for header is now set using the common headers library by passing the request object through, so we no longer need to separately pass the ip through to the config function
BeckaL
force-pushed
the
AUT-2578/use-common-headers-in-all-services
branch
from
64354ea
to
4726215
Compare
|
andrew-moores
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Switches all services over to send common security headers, as part of the cloudfront initiative.
How to review
Related PRs
This has already been done for a few services, e.g. #1620