Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Netlify errors by migrating to bundlesize2 #1075

Merged
merged 1 commit into from
May 1, 2022

Conversation

domdomegg
Copy link
Contributor

@domdomegg domdomegg commented Apr 30, 2022

Checklist:

  • Documentation (N/A)
  • Tests (N/A)
  • Ready to be merged

@domdomegg
Copy link
Contributor Author

Meant to leave a better comment on this one...

Currently govuk-react uses bundlesize to make sure the bundle size is reasonable so it can be installed and used efficiently by downstream consumers. bundlesize depends on iltorb, which has been deprecated and has had some releases removed from its repo. This breaks the netlfiy build (specifically: when netlify tries to install dependencies, it needs to recompile iltorb from scratch, which requires Python, which it doesn't have - and therefore errors).

This PR replaces bundlesize with bundlesize2, which is largely a drop-in replacement. It's made by the same author, and has been indicated to be the successsor to bundlesize. It doesn't have the same iltorb problems as bundlesize.

Also see siddharthkp/bundlesize#370

@penx penx merged commit 0adf94c into govuk-react:main May 1, 2022
@domdomegg domdomegg deleted the domdomegg/bundlesize2 branch May 1, 2022 11:46
@penx penx mentioned this pull request Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants