Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/loading box dependency #189

Merged
merged 9 commits into from Apr 6, 2018
Merged

Bugfix/loading box dependency #189

merged 9 commits into from Apr 6, 2018

Commits on Apr 6, 2018

  1. remove package lock, using yarn as standard

    @penx
    penx committed Apr 6, 2018
    Configuration menu
    Copy the full SHA
    8f35a90 View commit details
    Browse the repository at this point in the history

  2. update yarn lock

    @penx
    penx committed Apr 6, 2018
    Configuration menu
    Copy the full SHA
    96bbb40 View commit details
    Browse the repository at this point in the history

  3. remove loading box package lock

    @penx
    penx committed Apr 6, 2018
    Configuration menu
    Copy the full SHA
    0cd91ea View commit details
    Browse the repository at this point in the history

  4. fix to eslint command to include subfolders of src

    @penx
    penx committed Apr 6, 2018
    Configuration menu
    Copy the full SHA
    193b72a View commit details
    Browse the repository at this point in the history

  5. hoc devDependencies

    @penx
    penx committed Apr 6, 2018
    Configuration menu
    Copy the full SHA
    4620b74 View commit details
    Browse the repository at this point in the history

  6. storybook dependencies

    @penx
    penx committed Apr 6, 2018
    Configuration menu
    Copy the full SHA
    b5f4b70 View commit details
    Browse the repository at this point in the history

  7. @govuk-react/storybook as dependency of govuk-react (temporary) 

    eslint needs to be configured to pick up exports that aren't in package.json

see import-js/eslint-plugin-import#1049

In the meantime we are including @govuk-react/storybook as a dependency, which will help ensure subdependencies are included.
    @penx
    penx committed Apr 6, 2018
    Configuration menu
    Copy the full SHA
    4d9ce93 View commit details
    Browse the repository at this point in the history

  8. loading-box as dependency of govuk-react

    @penx
    penx committed Apr 6, 2018
    Configuration menu
    Copy the full SHA
    cb00d34 View commit details
    Browse the repository at this point in the history

  9. don't run eslint on node_modules on travis

    @penx
    penx committed Apr 6, 2018
    Configuration menu
    Copy the full SHA
    3612e24 View commit details
    Browse the repository at this point in the history